Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build regression with updated Seabios #131

Merged
merged 2 commits into from Apr 23, 2020

Conversation

@samueldr
Copy link
Member

samueldr commented Apr 23, 2020

From Hydra:

A mixture of updates broke our previous hack, but that same mixture of updates allows us to rely on the relatively new EDID support in both QEMU and the Kernel.

The best advantage this gives us is complete control over the resolution with the screen width/height options, as they now set the resolution unconditionally instead of relying on a list of known modes and a selected mode.

samueldr added 2 commits Apr 23, 2020
This removes the need for the gnarly hack we were using to get a custom
resolution.
@samueldr samueldr force-pushed the samueldr-wip:fix/seabios-regression branch from 36400b0 to fd66311 Apr 23, 2020
@samueldr samueldr merged commit 1a51850 into NixOS:master Apr 23, 2020
3 checks passed
3 checks passed
Parse_nix
Details
Documentation
Details
Instantiation
Details
@samueldr samueldr deleted the samueldr-wip:fix/seabios-regression branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.