Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initrd: use pkgs.kmod for modprobe instead of busybox #145

Open
wants to merge 1 commit into
base: master
from

Conversation

@thefloweringash
Copy link
Member

thefloweringash commented May 6, 2020

Removes "Unknown symbol" errors while booting:

[    3.817788] bmp280_spi: Unknown symbol bmp280_regmap_config (err -2)
[    3.817844] bmp280_spi: Unknown symbol bmp280_common_probe (err -2)
[    3.823219] bmp280_spi: Unknown symbol bmp280_dev_pm_ops (err -2)
[    3.829247] bmp280_spi: Unknown symbol bmp180_regmap_config (err -2)

This might come down to personal taste a little. I was having trouble getting the right modules loaded for usb rndis while working on the lg hammerhead. The actual resolution to that was #141, but I tried this as well after seeing the "Unknown symbol" errors printed. It does makes the boot log shorter and cleaner.

Removes "Unknown symbol" errors while booting:

[    3.817788] bmp280_spi: Unknown symbol bmp280_regmap_config (err -2)
[    3.817844] bmp280_spi: Unknown symbol bmp280_common_probe (err -2)
[    3.823219] bmp280_spi: Unknown symbol bmp280_dev_pm_ops (err -2)
[    3.829247] bmp280_spi: Unknown symbol bmp180_regmap_config (err -2)
@samueldr
Copy link
Member

samueldr commented May 6, 2020

I haven't had the time to check yet, but here's my main concern:

  • What's the added weight to the closure?

We have an extremely tight budget in stage-1, where I'm already over the ~7MiB for the compressed stage-1 (excluding kernel).

Assuming it doesn't add much, what else depends on what this depends on? E.g. right now I think there's systemd-udevd that brings in a bunch of deps that it's the only thing depending on. Stage-1 needs a udev-like tool, but not necessarily that one. It will probably be replaced due to these budgetary restrictions.

As an added side-note, this is all assuming we may actually move the goalposts a bit for that stage-1, and make it also a stage-0, where it would kexec a bog standard NixOS stage-1+kernel. In that sense, I expect this will somewhat change some of the design decisions. (I'm now thinking, maybe we want to always switch_root into the NixOS stage-1 even if we don't kexec?)

@samueldr
Copy link
Member

samueldr commented May 25, 2020

The increase is of ~68KiB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.