Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
initial port to motorola-potter (Moto G5 Plus) #147
This is more or less a copy of motorola-addison with some changes in the kernel config that I made experimentally and need to review before merge.
Good news: it boots, I can connect to it with adb or with USB networking
In the next few days I have another device arriving, hopefully then I won't need to use this one for actual, y'know, telephony, and will be able to flash the rootfs normally
Some extra credits:
I'm assuming the white LED is not enabled at all (or only when charging), from what I'm reading.
I'm assuming the following is the LED:
Can you add a patch enabling the LED by default, like the following ones?
This is a new standard I'm trying to get going in Mobile NixOS, where devices with a LED should default to enabling and lighting it with the kernel, as
(For multi-colour LEDs, one colour should be used for
Just saying, in case you're cleaning up your commits, the novel changes and patches should stay separate commits. Here I mean the mmc patch addition, and possibly the LED enabling patch. Though if you do some fixups to the device config or kernel build, or even those patches, a rebase would be well-received :).
Oopsie, it's possible the LED thing can't work.
It uses leds-atc, which for addison will not work as expected. First, the driver needs to be tweaked to allow setting an initial state (trivial enough). Though, once done, it works, but something resets the state of the LED hardware-wise just after it lights-up at boot.
The thing that resets it doesn't notify the kernel; the kernel still thinks it's turned on if you try and read information in the
You may want to try applying that commit and see if it works for your device, but I guess chances are low.
Just FTR, this PR is superseded by https://github.com/NixOS/mobile-nixos/compare/master...telent:motorola-potter?expand=1 which starts from a more recent upstream (post-#152) and has better commit messages. At least, longer ones.
I'm going to give the led thing a go on that PR and let you know how ti goes