Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and fixup the "taxonomy" #148

Merged
merged 9 commits into from May 23, 2020
Merged

Conversation

@samueldr
Copy link
Member

samueldr commented May 15, 2020

It wasn't clear when I started at first, and I was still dragging baggage from initial implementations.

Now, I have documented how it all works. Note that I have documented families, even though I have no family implemented yet. This is mainly to show how I thought about it, and I know it's 99% definitive we implement them that way. We already know that some Pixel devices share family traits (e.g. taimen/walleye → wahoo).

Though, since I don't have a family to "fix" with this cleaned-up taxonomy, I didn't end up implementing families' implementation details.


There is one breaking change, the QEMU system type name changed. I think that all builds should have been using build.vm or build.default so it shouldn't actually break things.

samueldr added 9 commits May 14, 2020
This is a bit of a premature optimization, as we don't have a family
to implement and validate _just yet_, but we're still making the
structure ready as both `asus-dumo` and `google-taimen` are subject to
receive family members as soon as someone can test them.
It didn't make sense to stuff that into systems anyway, it's baggage
from the first steps of making Mobile NixOS.
It didn't make sense to stuff that into systems anyway, it's baggage
from the first steps of making Mobile NixOS.

This is a *part* of android system types, so why stuff it into `system`
at the root??
It didn't make sense to stuff that into systems anyway, it's baggage
from the first steps of making Mobile NixOS.

This is a *part* of depthcharge system type, so why stuff it into `system`
at the root??
In addition, put the implementation of the build side-by-side with the
system type definition. It made no sense to keep those where they were,
as it was baggage from the earlier implementation of the project.
@samueldr samueldr merged commit f71dbbb into NixOS:master May 23, 2020
3 checks passed
3 checks passed
Parse_nix
Details
Documentation
Details
Instantiation
Details
@samueldr samueldr deleted the samueldr-wip:feature/families branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.