Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: add asus-x018d #175

Merged
merged 8 commits into from Jul 6, 2020
Merged

device: add asus-x018d #175

merged 8 commits into from Jul 6, 2020

Conversation

@samueldr
Copy link
Member

samueldr commented Jun 29, 2020

Another Mediatek device. Before I received the previous one as a donation for porting purposes, I had intended this device to be the first Mediatek device.

Since the previous port went so well (really, if you forget about the brickiness), I decided to just do it.

I spent around a day's work on this. Not bad when you consider the following amusing fact.

Amusing fact: there are no custom ROMs for this phone. Additionally, there seems to be no TWRP builds with a fresh custom kernel, the only TWRP floating around uses the vendor's kernel build!

This makes Mobile NixOS the first and only alternative system for the Asus Zenfone Max Plus (M1) 馃帀

This device has only a basic feature set working, it boots, graphics work, inputs work, the older androidusb gadget works.


Thing worthy of note

fb-refresher

This changes the quirk name qualcomm.msm-fb-refresher to fb-refresher, but NOT the package. Why? Because the package is a third party one, and it is its name!

This SoC (or maybe the device?) seems to exhibit the same issue as Qualcomm devices, no page flips on write! So in the end it might have been a quirk that came from an early rush to implement the minimum required for Android? Who knows.

default-trigger

There is an implementation of default-trigger for this vintage of the mediatek LEDs driver. This may be useful for other older mediatek devices.

In addition, this is an example (not necessarily a good one) of how to handle adding that feature if needed. The jist of it is to somehow read the device tree property off of the node, and set it to the classdev for the LED. If the driver is not completely broken, it should automatically work.

@samueldr samueldr added the type: port label Jun 29, 2020
@samueldr samueldr merged commit e7426cc into NixOS:master Jul 6, 2020
3 checks passed
3 checks passed
Parse_nix
Details
Documentation
Details
Instantiation
Details
@samueldr samueldr deleted the samueldr-wip:device/asus-x018d branch Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can鈥檛 perform that action at this time.