Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling #225

Merged
merged 1 commit into from Oct 15, 2020
Merged

fix spelling #225

merged 1 commit into from Oct 15, 2020

Conversation

@J-Kirch
Copy link
Contributor

@J-Kirch J-Kirch commented Oct 13, 2020

No description provided.

@samueldr
Copy link
Member

@samueldr samueldr commented Oct 15, 2020

Hi! 👋

Thanks for the contribution!


For future contributions, I would like if the commit message included a bit more information, e.g.

initrd-kernel: Fix spelling in mobile.boot.stage-1.kernel.firmwares description

Sure, it's a bit on the long side, but that's a neat habit to pick up, to always describe succintly what the changes are doing.


Though it's fine enough to commit.

@samueldr samueldr merged commit 12a2743 into NixOS:master Oct 15, 2020
3 checks passed
@J-Kirch
Copy link
Contributor Author

@J-Kirch J-Kirch commented Oct 16, 2020

@samueldr note taken, thank you for the response.

@J-Kirch J-Kirch deleted the fix-spelling branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants