Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage-1: Handle (physical) keyboard input #242

merged 6 commits into from Nov 22, 2020


Copy link

@samueldr samueldr commented Nov 21, 2020

With this change set, the physical keyboard can be used to input passphrases and such.

Note that this is currently hardcoded to the "us" keyboard, only because other layouts are expected to be implemented in unison with locale-aware on-screen keyboard. The irony is not lost on me, a non-"us" keyboard user implementing the "us" keyboard only.

In fact, the on-screen keyboard will be able to re-use xkbcommon's knowledge of keyboard layouts! Much better than re-implementing it all!

See, we'll simply build the keyboard from return values of the scancodes at their expected locations! We should even be able to support "3rd layer" (alt gr) this way in a trivial manner.

So let's not keep this improvement from landing, while the internationalized keyboard issue is scheduled to be handled at a later time.

@samueldr samueldr added type: enhancement New feature or request topic: stage-1 stage-1, boot, init labels Nov 21, 2020
@samueldr samueldr force-pushed the feature/stage-1-keyboard-input branch 2 times, most recently from c646bce to bd6563f Compare November 22, 2020 21:27
@samueldr samueldr force-pushed the feature/stage-1-keyboard-input branch from bd6563f to a97cf09 Compare November 22, 2020 21:45
@samueldr samueldr merged commit 92b4eb0 into NixOS:master Nov 22, 2020
@samueldr samueldr deleted the feature/stage-1-keyboard-input branch November 22, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
topic: stage-1 stage-1, boot, init type: enhancement New feature or request
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants