stage-1: Handle (physical) keyboard input #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
added
type: enhancement
bew
reviewed
Nov 21, 2020
samueldr
force-pushed
the
feature/stage-1-keyboard-input
branch
2 times, most recently
from
c646bce
to
bd6563f
Compare
This allows keyboard input to be sent to it, thus supporting passphrase input using a physical keyboard. Additionally, don't show the focus ring on the only element.
samueldr
force-pushed
the
feature/stage-1-keyboard-input
branch
from
bd6563f
to
a97cf09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With this change set, the physical keyboard can be used to input passphrases and such.
Note that this is currently hardcoded to the "us" keyboard, only because other layouts are expected to be implemented in unison with locale-aware on-screen keyboard. The irony is not lost on me, a non-"us" keyboard user implementing the "us" keyboard only.
In fact, the on-screen keyboard will be able to re-use xkbcommon's knowledge of keyboard layouts! Much better than re-implementing it all!
See, we'll simply build the keyboard from return values of the scancodes at their expected locations! We should even be able to support "3rd layer" (alt gr) this way in a trivial manner.
So let's not keep this improvement from landing, while the internationalized keyboard issue is scheduled to be handled at a later time.