Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage-1: Use evdev bindings for recovery key #243

Merged
merged 7 commits into from Nov 22, 2020

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Nov 22, 2020

If you look at the changes, this was previously shelling out to a wrapper that, itself, was shelling-out to evtest to query the key states.

That was done as an extremely MVP way to check for specific keys.

This is now done through FFI bindings. They're not "good" bindings, but they are proper enough, and more importantly, done through the same exact previous abstraction.

What do I mean by "good" bindings? It'd need to have a fancy object oriented API rather than just being a direct use of the FFI bindings. Though, using FFI bindings sure is fine enough.

@samueldr samueldr force-pushed the samueldr-wip:feature/stage-1-ffi-evdev branch from fc95397 to 0643c36 Nov 22, 2020
@samueldr samueldr force-pushed the samueldr-wip:feature/stage-1-ffi-evdev branch 3 times, most recently from 5f01324 to f2ba27e Nov 22, 2020
samueldr added 7 commits Nov 21, 2020
It'll be, at first, bundled-in as-is in a library, then re-done through
evdev ffi.
It still uses evdev internally, but first let's change the interface,
*then* change the implementation details.
This could be done a build-time, but it's not like we actually need it
to be the freshest ever.

We're free to update it whenever.
It better describes the reasoning for the keys than the previous
"off-the-cuff" comment I left myself.
@samueldr samueldr force-pushed the samueldr-wip:feature/stage-1-ffi-evdev branch from f2ba27e to 841b835 Nov 22, 2020
@samueldr samueldr merged commit 63ab9f2 into NixOS:master Nov 22, 2020
3 checks passed
3 checks passed
Parse_nix
Details
Instantiation
Details
Documentation
Details
@samueldr samueldr deleted the samueldr-wip:feature/stage-1-ffi-evdev branch Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.