Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: add xiaomi-lavender #28

Merged
merged 9 commits into from Dec 4, 2019
Merged

device: add xiaomi-lavender #28

merged 9 commits into from Dec 4, 2019

Conversation

@samueldr
Copy link
Member

samueldr commented Oct 2, 2019

I will probably merge this soon, but I still need to do a clean rebuild of the system image with the fbdev hack applied.

Though, let's see some reviews if you have it in yourselves :).


This is an "omnibus" PR of all features the new device required.

This adds the required plumbing to use mainline usb gadget through configfs for rndis only. Since I have observed that the rndis function name can change, I have added a temporary quirk for this specific gadget. I assume that the coming google-taimen port will add an additional target using gadgetfs. Hopefully ffs and adb works better there. For xiaomi-lavender there were some issues enabling it with rndis_bam. I do not know if it is expected to work or not. I may need to dive deeper into a MIUI system.

Other notable changes:

  • gcc 4.9 kernel builder (ugh)
  • fbdev hack
@samueldr samueldr changed the title device: xiaomi-lavender device: add xiaomi-lavender Oct 2, 2019
@samueldr samueldr added the type: port label Oct 2, 2019
@samueldr samueldr force-pushed the xiaomi-lavender branch from 3e45baa to a5290c9 Oct 4, 2019
@samueldr samueldr changed the title device: add xiaomi-lavender [WIP] device: add xiaomi-lavender Oct 5, 2019
@samueldr samueldr force-pushed the xiaomi-lavender branch 3 times, most recently from e4c3810 to e09a653 Oct 9, 2019
@samueldr

This comment has been minimized.

Copy link
Member Author

samueldr commented Oct 9, 2019

I figured out in e09a653 what was up. This was keeping me up at night! Why was only this one device weird during initrd.

Turns out that pointing console= to a wrong location breaks things subtly.

@samueldr samueldr changed the title [WIP] device: add xiaomi-lavender device: add xiaomi-lavender Oct 10, 2019
@samueldr samueldr force-pushed the xiaomi-lavender branch from e09a653 to cce3725 Oct 27, 2019
@samueldr samueldr force-pushed the xiaomi-lavender branch from cce3725 to 93d1b67 Dec 4, 2019
samueldr added 9 commits Sep 26, 2019
Some kernel builds may require it.
This makes X11 work just fine on xiaomi-lavender.
This broke things subtly in the initrd.

The argument came from an OEM image. It might not affect Android images,
but it affects our setup.

It looks like it breaks console redirection and such things. This, in
turn, breaks systemd-udevd, aborting with the following:

```
close_nointr(fd) != -EBADF' failed at src/basic/fd-util.c:71, function safe_close(). Aborting
```

In turn, what tipped me off is this dmesg message:

```
Warning: unable to open an initial console.
```

Though there is no certainty it is related.
@samueldr samueldr force-pushed the xiaomi-lavender branch from 93d1b67 to 2da0634 Dec 4, 2019
@samueldr samueldr merged commit e1f0fda into master Dec 4, 2019
@samueldr samueldr deleted the xiaomi-lavender branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.