Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pine64-pinephone: add alsa ucm config files to make the audio work #337

Merged
merged 1 commit into from Apr 30, 2021

Conversation

Artturin
Copy link
Member

thanks to @zhaofengli for showing how to make it work in #331

@samueldr
Copy link
Member

(This also applies to @zhaofengli's PR)

Is there a canonical source we can get the files from, rather than ship yet another distro copy?

@samueldr
Copy link
Member

Hmm... too bad that the mobian contributor didn't send them upstream to the alsa-ucm-conf project.

@Artturin
Copy link
Member Author

Artturin commented Mar 16, 2021

maybe i should try making a pr https://github.com/alsa-project/alsa-ucm-conf looks active i wonder why mobian didn't

@Artturin
Copy link
Member Author

Artturin commented Mar 16, 2021

manjaro actually has a bit different ucm files compared to mobian https://gitlab.manjaro.org/manjaro-arm/packages/community/phosh/alsa-ucm-pinephone/-/commits/master/
i think the reason they haven't submitted them is to have more flexibility

@samueldr
Copy link
Member

samueldr commented Mar 16, 2021

I think, more importantly, the pine64 developers community should sync-up on a common "front", rather than haphazardly take parts from other projects all willy nilly :/

Right now, it's hard to know which source to follow, and for what reasons. And it is even harder for those kind of configurationey files, where things just get updated with vacuous reasons, at best.

@Artturin
Copy link
Member Author

Artturin commented Mar 16, 2021

manjaro actually took the files from Pine64-Arch and Pine64-Arch maybe got them from mobian
but this is a complicated issue and theres no audio at all on the pinephone rn on nixos without these files

@samueldr
Copy link
Member

Yes, I'm not meaning not to merge, it was a comment about the general situation that sucks.

@Pacman99
Copy link

Pacman99 commented Mar 16, 2021

This is probably a terrible way to compare. But my brother is on the latest mobian, while I'm on the latest arch. And I think the - very opinionated - consensus was that the arch audio was better. But there are many other factors outside of ucm conf to affect this.

Also I'm guessing the reason they haven't been up-streamed yet is because everything keeps changing all the way down to the kernel. So the optimal config likely isn't known yet.

@craigem
Copy link
Contributor

craigem commented Mar 16, 2021

While we're doing terrible comparisons, the Purism community image for the Pinephone is by far and away the most complete and performant image I've used yet.

@samueldr samueldr merged commit c4876fc into NixOS:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants