Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for xiaomi-tissot #47

Merged
merged 6 commits into from Nov 23, 2019
Merged

Conversation

@lheckemann
Copy link
Member

lheckemann commented Oct 28, 2019

Not sure what the most appropriate place to merge this is; I based it on a merge of xiaomi-lavender and better-demo because that's what I essentially based it on while working on it. We may want to rebase some of that out. I also included fbterm and stage-2 adb support for convenience, but those should probably be removed as well.

This adds support for the Xiaomi Mi A1 (tissot), based on the kernel used in LineageOS 15.1. LOS 16.0 has a newer 4.9-based kernel, but I haven't got that to boot yet.

What works:

  • Boot
  • X on fbdev
  • Touchscreen
  • USB OTG with keyboard/mouse
  • adb
  • USB RNDIS gadget (but the kernel produces lots of slow-path warnings when this is used)
  • USB-C hub with charging and HID devices
@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Oct 30, 2019

As far as rebasing, I can manage once I resume work after the trip.

@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Oct 30, 2019

I don't see any xiaomi-tissot related files in there... Something went wrong during a push? Uhhhh... something weird must have happened with github??

Copy link
Member

samueldr left a comment

In addition, the misc. commits unrelated will have to be rebased off this PR. If you don't have the time to get this done, or not sure, I can do it and ask you to validate it still works :).

devices/devices-to-json.rb Outdated Show resolved Hide resolved
devices/xiaomi-tissot/default.nix Outdated Show resolved Hide resolved
@samueldr samueldr added the type: port label Nov 7, 2019
@lheckemann lheckemann force-pushed the lheckemann:tissot-cleanup branch 3 times, most recently from bd0b79e to d09e514 Nov 16, 2019
@lheckemann lheckemann force-pushed the lheckemann:tissot-cleanup branch from d09e514 to e6cc9b5 Nov 16, 2019
@lheckemann

This comment has been minimized.

Copy link
Member Author

lheckemann commented Nov 16, 2019

How does this look? I've still got one commit from another branch of yours (cherry-picked with -x here currently), since we need to be able to pass makeFlags.

Copy link
Member

samueldr left a comment

In addition to the in-line comment, the kernel config needed a bit of normalization, through bin/kernel-normalize-config. This is the result.

devices/xiaomi-tissot/kernel/default.nix Outdated Show resolved Hide resolved
@lheckemann lheckemann force-pushed the lheckemann:tissot-cleanup branch from e6cc9b5 to a0b3c79 Nov 21, 2019
lheckemann added 3 commits Oct 27, 2019
Kernel patch is copied from xiaomi-lavender.
Patch copied from motorola-addison
@lheckemann lheckemann force-pushed the lheckemann:tissot-cleanup branch from a0b3c79 to f096699 Nov 21, 2019
@lheckemann

This comment has been minimized.

Copy link
Member Author

lheckemann commented Nov 21, 2019

Config renamed and normalised in all the commits (using filter-branch). Will need to go home and test this :)

@lheckemann lheckemann force-pushed the lheckemann:tissot-cleanup branch from f096699 to 0cabf85 Nov 21, 2019
@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Nov 21, 2019

You didn't need to normalize in all the past commits, as long as the result is right. Though it's fine to do so.

Hopefully everything's working and I can push that green button :).

@lheckemann

This comment has been minimized.

Copy link
Member Author

lheckemann commented Nov 23, 2019

Yep, works! 🎉

@samueldr samueldr merged commit 6198805 into NixOS:master Nov 23, 2019
@lheckemann lheckemann deleted the lheckemann:tissot-cleanup branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.