Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: Google Pixel 1 XL // google-marlin #51

Merged
merged 2 commits into from Nov 19, 2019

Conversation

@danielfullmer
Copy link
Contributor

danielfullmer commented Nov 19, 2019

WIP support for Pixel 1 XL.

Current status:

  • Boots to splash image (with correct RGB colors)
  • Serial terminal works (Using serial cable design from here)

I believe this should work with the non-XL pixel 1 (google-sailfish) with a simple s/marlin/sailfish/ + changing the resolution, but I don't have one to test with.

3024-4032-max

bootlog.txt

I'm currently having issues with bringing up the USB system. I believe the problem is a kernel crash when setting /sys/class/android_usb/android0/enable. This can be seen in the attached bootlog. The problem seems to be the line mentioning Internal error: Accessing user space memory outside uaccess.h routines:... in ffs_function_enable. Just wondering if anyone else has encountered something similar.

@danielfullmer danielfullmer changed the title device: Google Pixel 1 XL // google-marlin [WIP] device: Google Pixel 1 XL // google-marlin Nov 19, 2019
Copy link
Member

samueldr left a comment

Hi! 👋 Thanks for the amazing contribution!

This looks good. This changes so few things that this is almost ready to merge. Some minor changes as in-line comments.

devices/google-marlin/default.nix Outdated Show resolved Hide resolved
devices/google-marlin/kernel/default.nix Outdated Show resolved Hide resolved
Copy link
Member

samueldr left a comment

With the commented-out lines removed, this now looks almost ready to merge. Only one minor nitpick.

Can you split the commit as one for devices/google-marlin/default.nix and the other for adding devices/google-marlin/kernel/*?

@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Nov 19, 2019

Now. About USB gadget stuff: it's not only the Pixel 1. So this PR can be merged and the gadgetfs stuff figured out later. The xiaomi-lavender branch has a working sample for RNDIS, adb not working still. From memory, I had issues with the Pixel 2 XL, haven't tried it in today's port.

Basically, affecting the Pixel 2, it looks like some devices will crash hard with some inputs, some are just fine with weird input in the gadgetfs... It looks like it's not going to be a one-size-fits-all solution, and it is good to have more devices using the new gadgetfs stuff in the project.

If you want to look at the xiaomi-lavender branch and test, feel free, though it might not be trivial to get working.

@danielfullmer danielfullmer force-pushed the danielfullmer:google-marlin branch from 0b3650d to e566bf6 Nov 19, 2019
@danielfullmer danielfullmer marked this pull request as ready for review Nov 19, 2019
@danielfullmer danielfullmer changed the title [WIP] device: Google Pixel 1 XL // google-marlin device: Google Pixel 1 XL // google-marlin Nov 19, 2019
@samueldr samueldr added the type: port label Nov 19, 2019
@danielfullmer danielfullmer mentioned this pull request Nov 19, 2019
3 of 3 tasks complete
@danielfullmer danielfullmer force-pushed the danielfullmer:google-marlin branch from e566bf6 to 17e1529 Nov 19, 2019
@danielfullmer danielfullmer force-pushed the danielfullmer:google-marlin branch from 17e1529 to cbaa708 Nov 19, 2019
@samueldr samueldr merged commit 16c2581 into NixOS:master Nov 19, 2019
@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Nov 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.