Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] device: Pine64 PinePhone Don't be evil development kit // pine64-dont-be-evil #53

Closed
wants to merge 10 commits into from

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Nov 22, 2019

The initial commit is in #52.


I'm not sure this device will be kept in Mobile NixOS, since this is the devkit, but for lack of a proper PinePhone device, this will do.

Once a proper PinePhone is acquired by a contributor, the dont-be-evil device should be renamed, and fixed appropriately.


This only adds support for the "short touchscreen cable" devkit.

The touchscreen has been verified as working.

The status of the device is that it basically works with feature parity to the other android-based devices.


Note: Github ate the updated PR description... I'm not rewriting this just right now...

To implement (in the future)

  • Audio
  • Wi-Fi
  • Cellular

Those are simply "to-dos", not that there are issues implementing those, but that this port, as it is, supports as much of the pinephone as other android-based ports support their respective hardware.

samueldr added 4 commits Nov 22, 2019
The size wasn't fixed after aligning the result, this dividing the sizes
by as the alignment.
This is co-opted from a now-unused previous usage. In reality, this
means nothing.
System types generating a disk image should handle generating it.
For what it's worth right now :).
@samueldr samueldr added the type: port label Nov 22, 2019
@samueldr samueldr force-pushed the samueldr-wip:device/pine-dont-be-evil branch from 659179f to 9c3c979 Nov 22, 2019
# TODO : make kernel part of options.
kernel = pkgs.callPackage ./kernel {
kernelPatches = [];
#kernelPatches = pkgs.defaultKernelPatches;

This comment has been minimized.

@samueldr

samueldr Nov 22, 2019
Author Member

Remove this

(Additionally review the whole file compared to a recent device addition.)

@@ -0,0 +1,87 @@
{ lib, writeText, callPackage, buildUBoot, armTrustedFirmwareAllwinner, fetchFromGitLab }:

This comment has been minimized.

@samueldr

samueldr Nov 22, 2019
Author Member

Review this whole file before merging... This stinks of WIP.

samueldr added 6 commits Nov 22, 2019
What does this mean?

This means that it's possible to get a *full* disk image for a u-boot
using target. That full disk image can be flashed to a storage, e.g. an
SD card, and should be fully bootable.

It is expected that such u-boot using targets would be using u-boots
with android-like configurations. Mainly, reading the boot.img and
booting it.

At the moment, this may be requiring a couple patches to u-boot.
These are not yet included in the website / docs, but the device link
will link to the folder holding the README, thus the README will be
visible.
@samueldr samueldr force-pushed the samueldr-wip:device/pine-dont-be-evil branch from 9c3c979 to 5950544 Nov 22, 2019
@jimstutt
Copy link

@jimstutt jimstutt commented Jan 30, 2020

Is there a good reason why these PRs haven't been merged? Is this pinephone project still ongoing?

@FireyFly
Copy link

@FireyFly FireyFly commented Jan 30, 2020

I suspect it's pending people getting actual PinePhone hardware to test on. As far as I know mobile-nixos in general is very much still ongoing, and I suspect the interest around a PinePhone target is high. I'm intending to mess around with it (and hopefully contribute) once I receive the hardware myself.

@jimstutt
Copy link

@jimstutt jimstutt commented Jan 30, 2020

@knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Feb 27, 2020

My pinephone finally arrived. ❤️ Will give this a try.

@samueldr samueldr changed the title device: Pine64 PinePhone Don't be evil development kit // pine64-dont-be-evil [WIP] device: Pine64 PinePhone Don't be evil development kit // pine64-dont-be-evil Mar 8, 2020
@samueldr samueldr closed this in #96 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.