Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhybris: 2018-06-18 -> 2019-12-02 #65

Merged
merged 4 commits into from Dec 10, 2019

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Dec 10, 2019

Two big things

  • Upgrades libhybris to its latest version
  • Fixes issue with adbd with newer libhybris

The main issue with adbd (better described in commit messages and the patch) is that new versions of libhybris highly assume that you will be using libhybris with vendor libraries available.

This is not true here, and especially not with adbd in stage-1.

The adb daemon was running quite fine with the few bits of libhybris it was using, before they changed the behaviour. The added patch reverts the new behaviour to the older behaviour, which makes libhybris not load any libraries for adbd.

In the future, it might be ideal to extract the minimum libhybris required to run adbd, and rely on that instead.


This does mean that #30 will conflict, I'll rebase it on top of this PR.

samueldr added 2 commits Dec 10, 2019
This is used to get a slimmer libhybris for adbd for stage-1.

The previous behaviour (before 35976c201741cfc21c114615b8524db5367e034a)
was to rely on a "homegrown" system to get properties.

Starting with that new properties system, it will rely on the vendor
libraries, thus requiring all of them, plus the linker, to get
properties.

Turns out, adbd doesn't actively need anything from the vendor libraries
or from the actual propeties system.

So, it's fine to revert the change to get a working libhybris for
stage-1.

Though, what would be even better is to strip out only the minimum
requirements for adbd, and make a "mini hybris" that we can rely on for
adbd.
@samueldr samueldr force-pushed the samueldr-wip:feature/libhybris/update branch from ce5bef7 to 920e499 Dec 10, 2019
@samueldr samueldr merged commit 774dabf into NixOS:master Dec 10, 2019
@samueldr samueldr deleted the samueldr-wip:feature/libhybris/update branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.