Split up nix-search into two separate functions
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main intention behind this is that patching the functions should be easier. It also allows for experimenting with different displaying methods for the search result. The second argument to the `display` function has been removed in order to not dictate how the buffer should be displayed. Users can customize this with `display-buffer-alist`. Also, the fact that the display function is separate allows, for example, to store a search result somewhere and have it display later.
|
looks good! |
|
I made a few changes to nix-search.el to better work with nix 2.4. Also added some faces and stuff to make the display a little easier to read. Let me know if you have any issues with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main intention behind this is that patching the functions should be
easier. It also allows for experimenting with different displaying
methods for the search result.
The second argument to the
displayfunction has been removed in orderto not dictate how the buffer should be displayed. Users can customize
this with
display-buffer-alist.Also, the fact that the display function is separate allows, for
example, to store a search result somewhere and have it display later.