Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesPrioritize closing } over regular indentation #71
Conversation
This comment has been minimized.
This comment has been minimized.
|
cc @wedens |
This comment has been minimized.
This comment has been minimized.
wedens
commented
Jan 8, 2019
|
That seems to fix all issues listed in #69. Thanks! |
etu
approved these changes
Jan 8, 2019
|
Seems to work perfectly good! And good to have tests for this case for the future |
etu
merged commit e8921b8
into
NixOS:master
Jan 10, 2019
1 check passed
Travis CI - Pull Request
Build Passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
grahamc commentedJan 8, 2019
Fixes #69, I think.
cc @matthewbauer @etu