Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPrioritize closing } over regular indentation #71
Conversation
This comment has been minimized.
This comment has been minimized.
|
cc @wedens |
This comment has been minimized.
This comment has been minimized.
wedens
commented
Jan 8, 2019
|
That seems to fix all issues listed in #69. Thanks! |
etu
approved these changes
Jan 8, 2019
|
Seems to work perfectly good! And good to have tests for this case for the future |
etu
merged commit e8921b8
into
NixOS:master
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
grahamc commentedJan 8, 2019
Fixes #69, I think.
cc @matthewbauer @etu