Skip to content

Commit edfc5b2

Browse files
committed
ca-specific-schema.sql: add index on RealisationsRefs(referrer) and (outputPath)
For a typical desktop system (~2K packages) we can easily get 100K entries in RealisationsRefs. Without indices query for RealisationsRefs requires linear scan. RealisationsRefs(referrer) -------------------------- Inefficiency is seen as a 100% CPU load of nix-daemon for the following scenario: $ nix edit -f . bash # add unused environment variable, like FOO="1" # populate RealisationsRefs, build fresh system $ nix build -f nixos system --arg config '{ contentAddressedByDefault = true; }' $ nix edit -f . bash # add unused environment variable, like FOO="2" $ time nix build -f nixos system --arg config '{ contentAddressedByDefault = true; }' In this case `bash `will be rebuilt a few times and then rest of CPU time is spent on scanning RealisationsRefs table (about 5 CPU-minutes on my machine). Before the change: $ time nix build -f nixos system ... # step 4 above real 34m3,613s user 0m5,232s sys 0m0,758s Of all this time about 29.5 minutes are taken by nix-daemon's CPU time. After the change: $ time nix build -f nixos system ... # step 4 above real 4m50,061s user 0m5,038s sys 0m0,677s Of all this time about 1 minute is taken by nix-daemon's CPU time. Most of the time is spent polling for non-existent realisations on cache-nixos.org. Realisations(outputPath) ------------------------ After running CA system for two weeks I got ~1M entries in Realisations table. `nix-collect-garbage` became very slow (seemingly 100 path deletions per second). It happens due to a slow cascading delete from Realisations triggered by deletion from ValidPaths. The fix is to add an index on primary key from ValidPaths(id) that triggers cascading deletions. Before the change: $ time nix-collect-garbage -d --max-freed 100G <interrupted before finish, took too long> real 23m32.411s user 17m49.679s sys 4m50.609s Most of time was spent in re-scanning Realisations table on each path deletion. After the change: $ time nix-collect-garbage -d --max-freed 100G real 8m43.226s user 6m16.317s sys 1m40.188s Time is spent scanning sqlite indices and in kernel when unlinking directories.
1 parent 6717947 commit edfc5b2

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/libstore/ca-specific-schema.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,8 @@ create table if not exists RealisationsRefs (
1919
foreign key (referrer) references Realisations(id) on delete cascade,
2020
foreign key (realisationReference) references Realisations(id) on delete restrict
2121
);
22+
23+
-- used by QueryRealisationReferences
24+
create index if not exists IndexRealisationsRefs on RealisationsRefs(referrer);
25+
-- used by cascade deletion when ValidPaths is deleted
26+
create index if not exists IndexRealisationsRefsOnOutputPath on Realisations(outputPath);

src/libstore/local-store.cc

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ int getSchema(Path schemaPath)
7979

8080
void migrateCASchema(SQLite& db, Path schemaPath, AutoCloseFD& lockFd)
8181
{
82-
const int nixCASchemaVersion = 2;
82+
const int nixCASchemaVersion = 3;
8383
int curCASchema = getSchema(schemaPath);
8484
if (curCASchema != nixCASchemaVersion) {
8585
if (curCASchema > nixCASchemaVersion) {
@@ -130,6 +130,17 @@ void migrateCASchema(SQLite& db, Path schemaPath, AutoCloseFD& lockFd)
130130
txn.commit();
131131
}
132132

133+
if (curCASchema < 3) {
134+
SQLiteTxn txn(db);
135+
// Apply new indices added in this schema update.
136+
db.exec(R"(
137+
-- used by QueryRealisationReferences
138+
create index if not exists IndexRealisationsRefs on RealisationsRefs(referrer);
139+
-- used by cascade deletion when ValidPaths is deleted
140+
create index if not exists IndexRealisationsRefsOnOutputPath on Realisations(outputPath);
141+
)");
142+
txn.commit();
143+
}
133144
writeFile(schemaPath, fmt("%d", nixCASchemaVersion));
134145
lockFile(lockFd.get(), ltRead, true);
135146
}

0 commit comments

Comments
 (0)