Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature freeze for nix 1.12? #1806

Closed
shlevy opened this Issue Jan 18, 2018 · 14 comments

Comments

Projects
None yet
8 participants
@shlevy
Copy link
Member

shlevy commented Jan 18, 2018

nix 1.12 has been in development for 2 years, and new features (e.g. pure mode) keep getting added with no roadmap or timeline. As a step toward a release, it would be great if we could schedule a point after which no new features would go into 1.12 (instead slated for 1.13) and only fixes, documentation, polish, etc. would be merged in.

@shlevy shlevy closed this Jan 19, 2018

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 19, 2018

Can you comment on why you closed this?

@shlevy

This comment has been minimized.

Copy link
Member Author

shlevy commented Jan 20, 2018

I'm no longer interested in pursuing this and closing it is the only way to remove it from my list of open issues.

I will note that I have pursued the goal of some kind of timeline for the 1.12 release for a year at least, through several communication channels, and not received any kind of response or even acknowledgment from @edolstra , so I don't recommend any one else to bother, though of course they are free to do so.

@gilligan

This comment has been minimized.

Copy link

gilligan commented Jan 20, 2018

Well that sucks ;( I was hoping that there was any kind of organization going on between the (few) maintainers of nix.

Is there really no plan or roadmap of any kind at all? Considering this is the nix project and not some random joe’s movies catalog bash script I find that somewhat unsettling.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Jan 20, 2018

I just want to note that I/we've been doing underlying organizational work in the background for several months on a few fronts. I think we'll be able to get to a better place here soon. It has taken quite some time because in a lot of ways, this sort of work is harder than code changes. I'm hopeful I'll have some good news soon.

@wmertens

This comment has been minimized.

Copy link
Contributor

wmertens commented Jan 20, 2018

@grahamc perfect is the enemy of good - even though it can be very hard to show incomplete work (guilty), it would be good if you can already hint on what you are working on so that we can cheer from the sidelines.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Jan 21, 2018

@wmertens unfortunately, in this case I think it would be risky to show incomplete work. However maybe it is a small comfort to know I'm not aiming for perfect 🙃. I'll try not to go more than a week without a further update.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Jan 25, 2018

Just a quick note: There has been some cool progress and traction on the organizational work. I'm feeling hopeful. Consider this the further update for the week, and I hope to have more information to share in another week or so.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 25, 2018

Thanks!! This sort of work is hard, very important, and commonly a challenge in open-source projects. Just want to say your efforts are appreciated and let us know how we can best help!

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Jan 31, 2018

Eelco, Rob, Shea, and I have been talking over the past couple weeks on how to improve Nix’s project organization. More on that quite soon, but here is something definite:

  • Nix 1.12 is now feature-frozen
  • Nix 1.12 will be released as Nix 2.0
  • It will be 2.0 because it removes some functionality commands which were in 1.11, like nix-push
  • Nix 2.0’s new UI will still be marked "unstable" to allow us to change it, and evolve it based on user feedback.
  • NixOS Unstable will update very soon to use Nix 2.0-pre
  • 18.03 will ship with Nix 2.0

I can't thank @edolstra, @rbvermaa, and @shlevy enough for working together on this!

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Jan 31, 2018

This is extraordinarily minor but since 2.0 is in our near future thought I'd share a Nixpkgs patch I'm sitting on--maybe someone can apply it as part of setting default to 2.0?

Otherwise warnings are emitted at least once on ever nix invocation due to use of obsolete (removed) setting, which is annoying 😇 .

From 1dff8ba74e88f519a835eade0a9ba9172d627f79 Mon Sep 17 00:00:00 2001
From: Will Dietz <w@wdtz.org>
Date: Tue, 30 Jan 2018 15:34:42 -0600
Subject: [PATCH] drop obsolete nix.conf setting "signed-binary-caches"

---
 nixos/modules/services/misc/nix-daemon.nix | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/nixos/modules/services/misc/nix-daemon.nix b/nixos/modules/services/misc/nix-daemon.nix
index beca820d2d6..9036fc18c9c 100644
--- a/nixos/modules/services/misc/nix-daemon.nix
+++ b/nixos/modules/services/misc/nix-daemon.nix
@@ -47,9 +47,6 @@ let
         trusted-binary-caches = ${toString cfg.trustedBinaryCaches}
         binary-cache-public-keys = ${toString cfg.binaryCachePublicKeys}
         auto-optimise-store = ${boolToString cfg.autoOptimiseStore}
-        ${optionalString cfg.requireSignedBinaryCaches ''
-          signed-binary-caches = *
-        ''}
         trusted-users = ${toString cfg.trustedUsers}
         allowed-users = ${toString cfg.allowedUsers}
         $extraOptions
-- 
2.16.1
@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Jan 31, 2018

@dtzWill Thanks, NixOS/nixpkgs@700e21d does that and bunch of other 2.0 related config changes.

@garbas garbas referenced this issue Jan 31, 2018

Merged

Issue 2018/02 #46

@mogorman

This comment has been minimized.

Copy link
Contributor

mogorman commented Feb 1, 2018

I take it there is no way to get my trivial 2 year old patch in before the freeze @edolstra
#767

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Feb 28, 2018

Here is an update: NixOS/rfcs#25

@copumpkin

This comment has been minimized.

Copy link
Member

copumpkin commented Mar 1, 2018

Sorry about that, @mogorman. Hoping that with more of us keeping an eye on the PR landscape it'll be harder for work like yours to get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.