Skip to content

Remove perl#1027

Merged
edolstra merged 4 commits into
NixOS:masterfrom
shlevy:remove-perl
Mar 31, 2017
Merged

Remove perl#1027
edolstra merged 4 commits into
NixOS:masterfrom
shlevy:remove-perl

Conversation

@shlevy

@shlevy shlevy commented Aug 12, 2016 •
edited by domenkozar
Loading

Copy link
Copy Markdown
Member

@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

@edolstra please merge this one, not the others. Still working on nix-perl package.

@shlevy shlevy mentioned this pull request Aug 12, 2016
Closed
12 tasks
@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

Incorporates #1026 #1023 #1018 #997 #981

@shlevy shlevy added this to the perl-to-c++ milestone Aug 12, 2016
@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

@edolstra nix-perl added, ready to merge

@domenkozar

domenkozar commented Aug 12, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Here's a Hydra jobset building this branch: https://headcounter.org/hydra/eval/330058 (debs/rpms fail to build, some tests fail)

@shlevy shlevy mentioned this pull request Aug 12, 2016
Closed
@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

FYI NixOS/nixpkgs#17697 is relevant to the copy-closure and remote builds tests

@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

@domenkozar Can you use release-16.03 for the nixpkgs checkout? That's what nix master on hydra.nixos.org uses.

@domenkozar

domenkozar commented Aug 12, 2016

Copy link
Copy Markdown
Member

Done

@edolstra

edolstra commented Aug 12, 2016

Copy link
Copy Markdown
Member

@shlevy One giant PR won't make things easier to review. I prefer the smaller ones.

@shlevy

shlevy commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

Can you review on the smaller ones then merge here once it's all OK? There were several non-trivial cleanups.

@vcunat vcunat mentioned this pull request Aug 31, 2016
Merged
7 tasks
@copumpkin

copumpkin commented Nov 21, 2016

Copy link
Copy Markdown
Member

Is this basically done? What's left?

@domenkozar

domenkozar commented Nov 21, 2016

Copy link
Copy Markdown
Member

#1023 #981

@shlevy

shlevy commented Nov 21, 2016

Copy link
Copy Markdown
Member Author

#1027

@copumpkin

copumpkin commented Nov 21, 2016

Copy link
Copy Markdown
Member

Error: infinite loop detected

On Nov 21, 2016, at 13:39, Shea Levy notifications@github.com wrote:

#1027

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@shlevy

shlevy commented Nov 21, 2016

Copy link
Copy Markdown
Member Author

😁 whoops, the last 4 commits here aren't covered in the other PRs

@domenkozar domenkozar mentioned this pull request Jan 19, 2017
Merged
@shlevy

shlevy commented Jan 20, 2017

Copy link
Copy Markdown
Member Author

@edolstra Rebased on #1023. The nix-perl package added here is a good place to add the perl nix-copy-closure if you decide we should go that route.

@shlevy

shlevy commented Feb 7, 2017

Copy link
Copy Markdown
Member Author

@edolstra rebased!

@domenkozar

domenkozar commented Feb 8, 2017

Copy link
Copy Markdown
Member

@edolstra & @shlevy thank you so much for this hard work! :D

@shlevy

shlevy commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

@edolstra ping

@edolstra

edolstra commented Feb 17, 2017

Copy link
Copy Markdown
Member

Could nix-perl be changed into a "regular" CPAN-style Perl package? I.e. with a Makefile.PL (or build.PL) instead of a autoconf/automake build system. That would make dependency handling easier. (E.g. you can just say requires DBI;.) It will also allow it to be used in Nixpkgs using buildPerlPackage.

@shlevy

shlevy commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

I don't really know anything about that system, but I suppose so. The biggest question is whether we can pull in the dependency on the nix libs and do the nix-instantiate calls to pull out the nix config from config.nix

@domenkozar domenkozar modified the milestones: nix-1.12, perl-to-c++ Mar 24, 2017
@shlevy

shlevy commented Mar 29, 2017

Copy link
Copy Markdown
Member Author

@edolstra Any thoughts on this?

@zimbatm

zimbatm commented Mar 29, 2017

Copy link
Copy Markdown
Member

Is that the last blocker for the 1.12 release?

@shlevy

shlevy commented Mar 29, 2017

Copy link
Copy Markdown
Member Author

FWIW, I don't think making nix-perl a CPAN package should be a blocker here. As things currently stand nix-perl can be built using standard autoconf tooling.

@zimbatm

zimbatm commented Mar 29, 2017

Copy link
Copy Markdown
Member

Agreed, this is already an improvement. One thing at a time :)

Can you rebase to resolve the merge conflicts?

@shlevy

shlevy commented Mar 29, 2017

Copy link
Copy Markdown
Member Author

Once I get approval otherwise, yep! Or I'll just merge it and resolve during the merge.

@shlevy shlevy requested a review from edolstra March 29, 2017 16:45
edolstra
edolstra reviewed Mar 30, 2017
View reviewed changes
Comment thread release.nix Outdated
[ (builtins.getAttr system jobs.build) curl bzip2 xz pkgconfig pkgs.perl ]
++ lib.optional stdenv.isLinux libsodium;

configureFlags = ''

@edolstra edolstra Mar 30, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs.

@shlevy shlevy Mar 30, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@edolstra edolstra merged commit a75475c into NixOS:master Mar 31, 2017
@copumpkin

copumpkin commented Mar 31, 2017

Copy link
Copy Markdown
Member

\o/ \o/ \o/

@zimbatm

zimbatm commented Mar 31, 2017

Copy link
Copy Markdown
Member

Wooot! Can we get a release now? ^_^

@tomberek

tomberek commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

1.11.16 still has a perl dependency, is that correct? I'm trying boostrap from source into arm7l and eventually ran into this:

Can't locate Nix/Config.pm in @INC (you may need to install the Nix::Config module) (@INC contains: 
/usr/local/lib/perl5/site_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /usr/local/lib/perl5/si
te_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /etc/perl /usr/lib/perl/site_perl/5.20.0/ /usr
/lib/perl/site_perl/5.20.0 /usr/lib/perl/vendor_perl/5.20.0/ /usr/lib/perl/vendor_perl/5.20.0 /usr/l
ib/perl/5.20.0/ /usr/lib/perl/5.20.0 /usr/local/lib/site_perl /usr/lib/perl/5.20.0 .) at ./nix-chann
el line 7.

@shlevy

shlevy commented Jan 19, 2018

Copy link
Copy Markdown
Member Author

Yes, it's only 1.12

Ma27 pushed a commit to Ma27/nix that referenced this pull request Mar 8, 2026
testing: drop compression from truncated nar test
0d24aee 
some versions of zstd enable checksumming, some don't. don't use it.

fixes NixOS#1027

Change-Id: I06811072d9e56a682a792f084cf76a81c7b5b4ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra edolstra left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

nix-1.12

Development

Successfully merging this pull request may close these issues.

7 participants

@shlevy @domenkozar @edolstra @copumpkin @zimbatm @tomberek @ysangkok