Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove perl #1027

Merged
merged 4 commits into from Mar 31, 2017
Merged

Remove perl #1027

merged 4 commits into from Mar 31, 2017

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Aug 12, 2016

@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

@edolstra please merge this one, not the others. Still working on nix-perl package.

@shlevy shlevy mentioned this pull request Aug 12, 2016
12 tasks
@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

Incorporates #1026 #1023 #1018 #997 #981

@shlevy shlevy added this to the perl-to-c++ milestone Aug 12, 2016
@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

@edolstra nix-perl added, ready to merge

@domenkozar
Copy link
Member

domenkozar commented Aug 12, 2016

Here's a Hydra jobset building this branch: https://headcounter.org/hydra/eval/330058 (debs/rpms fail to build, some tests fail)

@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

FYI NixOS/nixpkgs#17697 is relevant to the copy-closure and remote builds tests

@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

@domenkozar Can you use release-16.03 for the nixpkgs checkout? That's what nix master on hydra.nixos.org uses.

@domenkozar
Copy link
Member

Done

@edolstra
Copy link
Member

@shlevy One giant PR won't make things easier to review. I prefer the smaller ones.

@shlevy
Copy link
Member Author

shlevy commented Aug 12, 2016

Can you review on the smaller ones then merge here once it's all OK? There were several non-trivial cleanups.

@copumpkin
Copy link
Member

Is this basically done? What's left?

@domenkozar
Copy link
Member

#1023 #981

@shlevy
Copy link
Member Author

shlevy commented Nov 21, 2016

#1027

@copumpkin
Copy link
Member

Error: infinite loop detected

On Nov 21, 2016, at 13:39, Shea Levy notifications@github.com wrote:

#1027


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@shlevy
Copy link
Member Author

shlevy commented Nov 21, 2016

😁 whoops, the last 4 commits here aren't covered in the other PRs

@shlevy
Copy link
Member Author

shlevy commented Jan 20, 2017

@edolstra Rebased on #1023. The nix-perl package added here is a good place to add the perl nix-copy-closure if you decide we should go that route.

@shlevy
Copy link
Member Author

shlevy commented Feb 7, 2017

@edolstra rebased!

@domenkozar
Copy link
Member

@edolstra & @shlevy thank you so much for this hard work! :D

@shlevy
Copy link
Member Author

shlevy commented Feb 17, 2017

@edolstra ping

@edolstra
Copy link
Member

Could nix-perl be changed into a "regular" CPAN-style Perl package? I.e. with a Makefile.PL (or build.PL) instead of a autoconf/automake build system. That would make dependency handling easier. (E.g. you can just say requires DBI;.) It will also allow it to be used in Nixpkgs using buildPerlPackage.

@shlevy
Copy link
Member Author

shlevy commented Feb 17, 2017

I don't really know anything about that system, but I suppose so. The biggest question is whether we can pull in the dependency on the nix libs and do the nix-instantiate calls to pull out the nix config from config.nix

@domenkozar domenkozar modified the milestones: nix-1.12, perl-to-c++ Mar 24, 2017
@shlevy
Copy link
Member Author

shlevy commented Mar 29, 2017

@edolstra Any thoughts on this?

@zimbatm
Copy link
Member

zimbatm commented Mar 29, 2017

Is that the last blocker for the 1.12 release?

@shlevy
Copy link
Member Author

shlevy commented Mar 29, 2017

FWIW, I don't think making nix-perl a CPAN package should be a blocker here. As things currently stand nix-perl can be built using standard autoconf tooling.

@zimbatm
Copy link
Member

zimbatm commented Mar 29, 2017

Agreed, this is already an improvement. One thing at a time :)

Can you rebase to resolve the merge conflicts?

@shlevy
Copy link
Member Author

shlevy commented Mar 29, 2017

Once I get approval otherwise, yep! Or I'll just merge it and resolve during the merge.

@shlevy shlevy requested a review from edolstra March 29, 2017 16:45
release.nix Outdated
[ (builtins.getAttr system jobs.build) curl bzip2 xz pkgconfig pkgs.perl ]
++ lib.optional stdenv.isLinux libsodium;

configureFlags = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@edolstra edolstra merged commit a75475c into NixOS:master Mar 31, 2017
@copumpkin
Copy link
Member

\o/ \o/ \o/

@zimbatm
Copy link
Member

zimbatm commented Mar 31, 2017

Wooot! Can we get a release now? ^_^

@tomberek
Copy link
Contributor

1.11.16 still has a perl dependency, is that correct? I'm trying boostrap from source into arm7l and eventually ran into this:

Can't locate Nix/Config.pm in @INC (you may need to install the Nix::Config module) (@INC contains: 
/usr/local/lib/perl5/site_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /usr/local/lib/perl5/si
te_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /etc/perl /usr/lib/perl/site_perl/5.20.0/ /usr
/lib/perl/site_perl/5.20.0 /usr/lib/perl/vendor_perl/5.20.0/ /usr/lib/perl/vendor_perl/5.20.0 /usr/l
ib/perl/5.20.0/ /usr/lib/perl/5.20.0 /usr/local/lib/site_perl /usr/lib/perl/5.20.0 .) at ./nix-chann
el line 7.

@shlevy
Copy link
Member Author

shlevy commented Jan 19, 2018

Yes, it's only 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants