New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove perl #1027

Merged
merged 4 commits into from Mar 31, 2017

Conversation

Projects
None yet
7 participants
@shlevy
Member

shlevy commented Aug 12, 2016

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

@edolstra please merge this one, not the others. Still working on nix-perl package.

Member

shlevy commented Aug 12, 2016

@edolstra please merge this one, not the others. Still working on nix-perl package.

@shlevy shlevy referenced this pull request Aug 12, 2016

Closed

Get rid of the Perl dependency #341

12 of 12 tasks complete
@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

Incorporates #1026 #1023 #1018 #997 #981

Member

shlevy commented Aug 12, 2016

Incorporates #1026 #1023 #1018 #997 #981

@shlevy shlevy added this to the perl-to-c++ milestone Aug 12, 2016

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

@edolstra nix-perl added, ready to merge

Member

shlevy commented Aug 12, 2016

@edolstra nix-perl added, ready to merge

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Aug 12, 2016

Member

Here's a Hydra jobset building this branch: https://headcounter.org/hydra/eval/330058 (debs/rpms fail to build, some tests fail)

Member

domenkozar commented Aug 12, 2016

Here's a Hydra jobset building this branch: https://headcounter.org/hydra/eval/330058 (debs/rpms fail to build, some tests fail)

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

FYI NixOS/nixpkgs#17697 is relevant to the copy-closure and remote builds tests

Member

shlevy commented Aug 12, 2016

FYI NixOS/nixpkgs#17697 is relevant to the copy-closure and remote builds tests

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

@domenkozar Can you use release-16.03 for the nixpkgs checkout? That's what nix master on hydra.nixos.org uses.

Member

shlevy commented Aug 12, 2016

@domenkozar Can you use release-16.03 for the nixpkgs checkout? That's what nix master on hydra.nixos.org uses.

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Aug 12, 2016

Member

Done

Member

domenkozar commented Aug 12, 2016

Done

@edolstra

This comment has been minimized.

Show comment
Hide comment
@edolstra

edolstra Aug 12, 2016

Member

@shlevy One giant PR won't make things easier to review. I prefer the smaller ones.

Member

edolstra commented Aug 12, 2016

@shlevy One giant PR won't make things easier to review. I prefer the smaller ones.

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Aug 12, 2016

Member

Can you review on the smaller ones then merge here once it's all OK? There were several non-trivial cleanups.

Member

shlevy commented Aug 12, 2016

Can you review on the smaller ones then merge here once it's all OK? There were several non-trivial cleanups.

@vcunat vcunat referenced this pull request Aug 31, 2016

Merged

Don't force-break SSL applications in shells #15571

3 of 7 tasks complete
@copumpkin

This comment has been minimized.

Show comment
Hide comment
@copumpkin

copumpkin Nov 21, 2016

Member

Is this basically done? What's left?

Member

copumpkin commented Nov 21, 2016

Is this basically done? What's left?

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar
Member

domenkozar commented Nov 21, 2016

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy
Member

shlevy commented Nov 21, 2016

@copumpkin

This comment has been minimized.

Show comment
Hide comment
@copumpkin

copumpkin Nov 21, 2016

Member

Error: infinite loop detected

On Nov 21, 2016, at 13:39, Shea Levy notifications@github.com wrote:

#1027


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Member

copumpkin commented Nov 21, 2016

Error: infinite loop detected

On Nov 21, 2016, at 13:39, Shea Levy notifications@github.com wrote:

#1027


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Nov 21, 2016

Member

😁 whoops, the last 4 commits here aren't covered in the other PRs

Member

shlevy commented Nov 21, 2016

😁 whoops, the last 4 commits here aren't covered in the other PRs

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Jan 20, 2017

Member

@edolstra Rebased on #1023. The nix-perl package added here is a good place to add the perl nix-copy-closure if you decide we should go that route.

Member

shlevy commented Jan 20, 2017

@edolstra Rebased on #1023. The nix-perl package added here is a good place to add the perl nix-copy-closure if you decide we should go that route.

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Feb 7, 2017

Member

@edolstra rebased!

Member

shlevy commented Feb 7, 2017

@edolstra rebased!

@domenkozar

This comment has been minimized.

Show comment
Hide comment
@domenkozar

domenkozar Feb 8, 2017

Member

@edolstra & @shlevy thank you so much for this hard work! :D

Member

domenkozar commented Feb 8, 2017

@edolstra & @shlevy thank you so much for this hard work! :D

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy
Member

shlevy commented Feb 17, 2017

@edolstra ping

@edolstra

This comment has been minimized.

Show comment
Hide comment
@edolstra

edolstra Feb 17, 2017

Member

Could nix-perl be changed into a "regular" CPAN-style Perl package? I.e. with a Makefile.PL (or build.PL) instead of a autoconf/automake build system. That would make dependency handling easier. (E.g. you can just say requires DBI;.) It will also allow it to be used in Nixpkgs using buildPerlPackage.

Member

edolstra commented Feb 17, 2017

Could nix-perl be changed into a "regular" CPAN-style Perl package? I.e. with a Makefile.PL (or build.PL) instead of a autoconf/automake build system. That would make dependency handling easier. (E.g. you can just say requires DBI;.) It will also allow it to be used in Nixpkgs using buildPerlPackage.

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Feb 17, 2017

Member

I don't really know anything about that system, but I suppose so. The biggest question is whether we can pull in the dependency on the nix libs and do the nix-instantiate calls to pull out the nix config from config.nix

Member

shlevy commented Feb 17, 2017

I don't really know anything about that system, but I suppose so. The biggest question is whether we can pull in the dependency on the nix libs and do the nix-instantiate calls to pull out the nix config from config.nix

@domenkozar domenkozar modified the milestones: nix-1.12, perl-to-c++ Mar 24, 2017

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Mar 29, 2017

Member

@edolstra Any thoughts on this?

Member

shlevy commented Mar 29, 2017

@edolstra Any thoughts on this?

@zimbatm

This comment has been minimized.

Show comment
Hide comment
@zimbatm

zimbatm Mar 29, 2017

Member

Is that the last blocker for the 1.12 release?

Member

zimbatm commented Mar 29, 2017

Is that the last blocker for the 1.12 release?

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Mar 29, 2017

Member

FWIW, I don't think making nix-perl a CPAN package should be a blocker here. As things currently stand nix-perl can be built using standard autoconf tooling.

Member

shlevy commented Mar 29, 2017

FWIW, I don't think making nix-perl a CPAN package should be a blocker here. As things currently stand nix-perl can be built using standard autoconf tooling.

@zimbatm

This comment has been minimized.

Show comment
Hide comment
@zimbatm

zimbatm Mar 29, 2017

Member

Agreed, this is already an improvement. One thing at a time :)

Can you rebase to resolve the merge conflicts?

Member

zimbatm commented Mar 29, 2017

Agreed, this is already an improvement. One thing at a time :)

Can you rebase to resolve the merge conflicts?

@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Mar 29, 2017

Member

Once I get approval otherwise, yep! Or I'll just merge it and resolve during the merge.

Member

shlevy commented Mar 29, 2017

Once I get approval otherwise, yep! Or I'll just merge it and resolve during the merge.

@shlevy shlevy requested a review from edolstra Mar 29, 2017

Show outdated Hide outdated release.nix
[ (builtins.getAttr system jobs.build) curl bzip2 xz pkgconfig pkgs.perl ]
++ lib.optional stdenv.isLinux libsodium;
configureFlags = ''

This comment has been minimized.

@edolstra

edolstra Mar 30, 2017

Member

Tabs.

@edolstra

This comment has been minimized.

@shlevy

shlevy Mar 30, 2017

Member

Fixed

@shlevy

shlevy Mar 30, 2017

Member

Fixed

@edolstra edolstra merged commit a75475c into NixOS:master Mar 31, 2017

@copumpkin

This comment has been minimized.

Show comment
Hide comment
@copumpkin

copumpkin Mar 31, 2017

Member

\o/ \o/ \o/

Member

copumpkin commented Mar 31, 2017

\o/ \o/ \o/

@zimbatm

This comment has been minimized.

Show comment
Hide comment
@zimbatm

zimbatm Mar 31, 2017

Member

Wooot! Can we get a release now? ^_^

Member

zimbatm commented Mar 31, 2017

Wooot! Can we get a release now? ^_^

@tomberek

This comment has been minimized.

Show comment
Hide comment
@tomberek

tomberek Jan 19, 2018

1.11.16 still has a perl dependency, is that correct? I'm trying boostrap from source into arm7l and eventually ran into this:

Can't locate Nix/Config.pm in @INC (you may need to install the Nix::Config module) (@INC contains: 
/usr/local/lib/perl5/site_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /usr/local/lib/perl5/si
te_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /etc/perl /usr/lib/perl/site_perl/5.20.0/ /usr
/lib/perl/site_perl/5.20.0 /usr/lib/perl/vendor_perl/5.20.0/ /usr/lib/perl/vendor_perl/5.20.0 /usr/l
ib/perl/5.20.0/ /usr/lib/perl/5.20.0 /usr/local/lib/site_perl /usr/lib/perl/5.20.0 .) at ./nix-chann
el line 7.

tomberek commented Jan 19, 2018

1.11.16 still has a perl dependency, is that correct? I'm trying boostrap from source into arm7l and eventually ran into this:

Can't locate Nix/Config.pm in @INC (you may need to install the Nix::Config module) (@INC contains: 
/usr/local/lib/perl5/site_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /usr/local/lib/perl5/si
te_perl/5.20.2/arm-linux-gnueabihf-thread-multi-64int /etc/perl /usr/lib/perl/site_perl/5.20.0/ /usr
/lib/perl/site_perl/5.20.0 /usr/lib/perl/vendor_perl/5.20.0/ /usr/lib/perl/vendor_perl/5.20.0 /usr/l
ib/perl/5.20.0/ /usr/lib/perl/5.20.0 /usr/local/lib/site_perl /usr/lib/perl/5.20.0 .) at ./nix-chann
el line 7.
@shlevy

This comment has been minimized.

Show comment
Hide comment
@shlevy

shlevy Jan 19, 2018

Member

Yes, it's only 1.12

Member

shlevy commented Jan 19, 2018

Yes, it's only 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment