Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nativeBuildInputs for nix-shell #2504

Open
wants to merge 1 commit into
base: master
from

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Oct 31, 2018

Now the nix-shell will generate a nix expression that looks like this:

with import <nixpkgs> {};
runCommand "shell" {
  nativeBuildInputs = [
    (...)
    (...)
    (...)
  ];
}

from

$ nix-shell --packages ... ... ...

Fixes the issue described in NixOS/nixpkgs#38657.

Now the nix-shell will generate a nix expression that looks like this:

with import <nixpkgs> {};
runCommand "shell" {
  nativeBuildInputs = [
    (...)
    (...)
    (...)
  ];
}

from

$ nix-shell --packages ... ... ...

Fixes the issue described in NixOS/nixpkgs#38657.
@MrChico
Copy link

@MrChico MrChico commented Apr 19, 2019

Any chance of this getting some love?

@matthewbauer
Copy link
Member Author

@matthewbauer matthewbauer commented Jul 10, 2019

Some cases could also screw this up, however. For instance in some cases you want to treat your dependencies as libraries (for zlib, libsystemd, etc.). For now it is probably safest to leave the behavior as is (with -p implying buildInputs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.