Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: make scheme configurable #2566

Merged
merged 2 commits into from Dec 9, 2018
Merged

s3: make scheme configurable #2566

merged 2 commits into from Dec 9, 2018

Conversation

@LnL7
Copy link
Member

LnL7 commented Dec 7, 2018

This enables using for http for S3 request for debugging or
implementations that don't have https configured. This is not a problem
for binary caches since they should not contain sensitive information.
Both package signatures and AWS auth already protect against tampering.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Dec 7, 2018

This enables using for http for S3 request for debugging or
implementations that don't have https configured.  This is not a problem
for binary caches since they should not contain sensitive information.
Both package signatures and AWS auth already protect against tampering.
@LnL7 LnL7 force-pushed the LnL7:s3-scheme branch from aafb2f8 to e300462 Dec 7, 2018
Copy link
Member

grahamc left a comment

Docs nit, but looks pretty good to me!

<para>
This enables using for http for S3 request for debugging or
implementations that don't have https configured. Should not
be used if the cache might contain sensitive information.

This comment has been minimized.

Copy link
@grahamc

grahamc Dec 7, 2018

Member

Let's put <example>https</example> (default) or <example>http</example> at the start, and then something like:

This option allows you to disable HTTPS for binary caches which don't support it. HTTPS should be used if the cache might contain sensitive information.

@LnL7 LnL7 force-pushed the LnL7:s3-scheme branch from e300462 to 5c25a92 Dec 7, 2018
@LnL7 LnL7 force-pushed the LnL7:s3-scheme branch from 5c25a92 to 77cc632 Dec 7, 2018
@grahamc
grahamc approved these changes Dec 8, 2018
Copy link
Member

grahamc left a comment

Looks nice to me.

@edolstra edolstra merged commit 18ecd08 into NixOS:master Dec 9, 2018
@LnL7 LnL7 deleted the LnL7:s3-scheme branch Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.