Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: update macOS version check to 10.12.2 #2594

Merged
merged 1 commit into from May 8, 2019

Conversation

@LnL7
Copy link
Member

commented Dec 20, 2018

Nixpkgs will drop support for <10.12 soon and thus a nix release built
using the 19.03 channel will also require a newer version of macOS.

See NixOS/nixpkgs#47678

installer: update macOS version check to 10.12.2
Nixpkgs will drop support for <10.12 soon and thus a nix release built
using the 19.03 channel will also require a newer version of macOS.

@LnL7 LnL7 force-pushed the LnL7:darwin-10.12.6 branch from db321e8 to 82f054d Dec 20, 2018

@matthewbauer

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

So we ended up reverting that PR. I think we should probably hold off on this bump until the 19.03 release. There were a lot more failures than originally expected & this will give people a few more months to upgrade their machines.

echo "$0: macOS $(sw_vers -productVersion) is not supported, upgrade to 10.10 or higher"
macos_major=$(sw_vers -productVersion | cut -d '.' -f 2)
macos_minor=$(sw_vers -productVersion | cut -d '.' -f 3)
if [ "$macos_major" -lt 12 ] || ([ "$macos_major" -eq 12 ] && [ "$macos_minor" -lt 6 ]); then

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer Mar 10, 2019

Member

@LnL7 Do we care about the minor version? I would think these would be compatible, although I haven't tested it.

This comment has been minimized.

Copy link
@LnL7

LnL7 Mar 10, 2019

Author Member

I don't know what version exactly, but the previous attempt definitively needed >10.12.2.

@grahamc grahamc merged commit 5713772 into NixOS:master May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.