Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parameters in S3 URLs #2703

Merged
merged 4 commits into from Feb 26, 2019
Merged

Conversation

@pradd
Copy link
Contributor

pradd commented Feb 25, 2019

This pull request adds proper support for S3 URL parameters.

Currently, an attempt to download artifacts with fetchTarball or fetchUrl fails for buckets residing in regions other than us-east-1. Nix manual states explicitly that, when using another region, the "region"
parameter should be passed. Which doesn't work since us-east-1 is hardcoded.

src/libstore/download.cc Outdated Show resolved Hide resolved
@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Feb 26, 2019

Looks good to me!

@pradd pradd force-pushed the pradd:support_s3_region_param branch from ac200c3 to 25573c1 Feb 26, 2019
@pradd pradd force-pushed the pradd:support_s3_region_param branch from 25573c1 to 06d6335 Feb 26, 2019
@edolstra edolstra merged commit ebd4d50 into NixOS:master Feb 26, 2019
@copumpkin

This comment has been minimized.

Copy link
Member

copumpkin commented Feb 26, 2019

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.