Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/manual: add note to `allowSubstitutes` advanced attribute #3255

Merged

Conversation

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Dec 3, 2019

As discussed on #nixos-dev, this adds a note to allowSubstitutes to tell users about the possible problem if systembuiltins.currentSystem.

I hate how I phrased it, maybe we can find a wording that’s easier to understand.

cc @7c6f434c @cleverca22 @Infinisil

Profpatsch added 2 commits Dec 3, 2019
This makes it possible to reference single attribute definitions,
for pointing people to their exact definition.
Copy link
Member

@Infinisil Infinisil left a comment

Wording makes sense to me, I'd be fine with that

Profpatsch added a commit to Profpatsch/nixpkgs that referenced this pull request Dec 3, 2019
The link in the note points to the `id` added in
NixOS/nix#3255, so it might take some time to
start working correctly.
Profpatsch added a commit to Profpatsch/nixpkgs that referenced this pull request Dec 3, 2019
The link in the note points to the `id` added in
NixOS/nix#3255, so it might take some time to
start working correctly.
@edolstra edolstra merged commit f4b9495 into NixOS:master Dec 4, 2019
Profpatsch added a commit to NixOS/nixpkgs that referenced this pull request Dec 4, 2019
The link in the note points to the `id` added in
NixOS/nix#3255, so it might take some time to
start working correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.