Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Adding depth limit to resolveExprPath #3268

Merged
merged 1 commit into from Dec 15, 2019

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Dec 13, 2019

There is no termination condition for evaluation of cyclical
expression paths which can lead to infinite loops. This addresses
one spot in the parser in a similar fashion as utils.cc/canonPath
does.

This issue can be reproduced by something like:

ln -s a b
ln -s b a

nix-instantiate -E 'import ./a'
There is no termination condition for evaluation of cyclical
expression paths which can lead to infinite loops. This addresses
one spot in the parser in a similar fashion as utils.cc/canonPath
does.

This issue can be reproduced by something like:

```
ln -s a b
ln -s b a

nix-instantiate -E 'import ./a'
```
@edolstra edolstra merged commit d89d995 into NixOS:master Dec 15, 2019
@d-goldin d-goldin deleted the d-goldin:limit_depth_resolveExprPath branch Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.