Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2984: attempt to copy if unlinking source directory fails #3321

Open
wants to merge 1 commit into
base: master
from

Conversation

@yorickvP
Copy link
Contributor

yorickvP commented Jan 15, 2020

We were seeing an error on single-user nix mode, where rename fails if the right permissions on the source path are missing. Since the paths are removed in sandbox mode anyways, we can use copyPath to work around this.

Testcase: nix-build '<nixpkgs>' -A documentation-highlighter --substituters ""

@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Feb 19, 2020

Hm, do you know why EACCES happens here?

@yorickvP

This comment has been minimized.

Copy link
Contributor Author

yorickvP commented Feb 19, 2020

I suspect the build creates an actualPath/.. with no write bit set. Being root will ignore that completely, but single-user mode would have a problem. That suggests we can also fix this problem with a well-placed chmod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.