Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Coverage per-platform #3322

Open
wants to merge 1 commit into
base: master
from

Conversation

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 15, 2020

I was quite confused in #3315 (comment) (sorry!) but shouldn't we do the coverage test on more platforms than just Linux? Say a missing header bug is Darwin (or Windows!) only?

@Ericson2314 Ericson2314 changed the title Coverage per-platform WIP: Coverage per-platform Jan 15, 2020
@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Jan 15, 2020

No, I don't think so. Since the tests are largely the same the coverage will be largely the same.

@Ericson2314

This comment has been minimized.

Copy link
Member Author

Ericson2314 commented Jan 15, 2020

I did get as far as finding http://logan.tw/posts/2015/04/28/check-code-coverage-with-clang-and-lcov/

If not coverage, then I think we should have a distinct attribute for building with PRECOMPILE_HEADERS=0 for all platforms.

@Ericson2314

This comment has been minimized.

Copy link
Member Author

Ericson2314 commented Jan 16, 2020

Reopened the original alternative #3323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.