Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI with and without precompiled headers on multiple platforms #3323

Open
wants to merge 1 commit into
base: master
from

Conversation

@Ericson2314
Copy link
Member

Ericson2314 commented Jan 15, 2020

Coverage isn't so good as it is linux-only.

Put system at the end as its idiomatic.

release.nix Outdated
@@ -166,7 +170,7 @@ let
with import nixpkgs { inherit system; };

let
toplevel = builtins.getAttr system jobs.build;
toplevel = builtins.getAttr system jobs.build.recompiled-headers;

This comment has been minimized.

Copy link
@matthewbauer

matthewbauer Jan 16, 2020

Member

this looks like a mistake

Coverage isn't so good as it is linux-only.
@Ericson2314 Ericson2314 force-pushed the Ericson2314:precompilation-explosion-release.nix branch from 61ec6ef to fb66f3e Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.