Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-store: add remote-store and remote-program query params #3344

Merged
merged 1 commit into from Feb 4, 2020

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 3, 2020

Brings the functionality of ssh-ng:// in sync with the legacy ssh://
implementation. Specifying the remote store uri enables various useful
things. eg.

$ nix copy --to ssh-ng://cache?remote-store=file://mnt/cache --all
Brings the functionality of ssh-ng:// in sync with the legacy ssh://
implementation.  Specifying the remote store uri enables various useful
things. eg.

    $ nix copy --to ssh-ng://cache?remote-store=file://mnt/cache --all
@@ -82,7 +84,9 @@ ref<FSAccessor> SSHStore::getFSAccessor()
ref<RemoteStore::Connection> SSHStore::openConnection()
{
auto conn = make_ref<Connection>();
conn->sshConn = master.startCommand("nix-daemon --stdio");
conn->sshConn = master.startCommand(

This comment has been minimized.

@LnL7

LnL7 Feb 3, 2020
Author Member

Might not be worth the effort, but this could be generalised between the 2 implementations to avoid some of duplication.

@edolstra edolstra merged commit db88cb4 into NixOS:master Feb 4, 2020
@LnL7 LnL7 deleted the LnL7:ssh-ng-remote-params branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.