Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #[macro_use] #3350

Merged
merged 1 commit into from Feb 10, 2020
Merged

Remove #[macro_use] #3350

merged 1 commit into from Feb 10, 2020

Conversation

@curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Feb 10, 2020

As of Rust 2018, #[macro_use] is no longer required in most circumstances, we can just use macros the same way as functions. I think it is generally a good idea to remove #[macro_use] when not needed, to stop macros from polluting the crate's global namespace.

https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macro_rules-style-macros

As of Rust 2018, macro_use is no longer required in most circumstances.
I think it is generally a good idea to remove these when not needed, to
stop them from polluting the crate's global namespace.
https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macro_rules-style-macros
@curiousleo curiousleo marked this pull request as ready for review Feb 10, 2020
@curiousleo curiousleo requested review from grahamc and edolstra Feb 10, 2020
@edolstra edolstra merged commit 94c9343 into NixOS:master Feb 10, 2020
@edolstra
Copy link
Member

@edolstra edolstra commented Feb 10, 2020

Thanks!

@curiousleo curiousleo deleted the curiousleo:no-macro-use branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.