Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Use nixpkgs#bashInteractive for dev-shell #3565
Instead of using system bash for dev-shell, uses nixpkgs#bashInteractive as discussed in #3107 (comment). If dev-shell is used for a flake with a toplevel nixpkgs input, it uses that nixpkgs per #3107 (comment).
Reused a lot of code from InstallableFlake - seems like that should maybe get factored out?
Updated to just create a bashInteractive InstallableFlake. InstallableFlake will only call lockFlake once, but this will ultimately still call lockFlake twice, because the bashInteractive installable will call it a second time.
Seems like preventing that would require being able to have a LockedFlake return a LockedFlake for one of its inputs, but not sure if that's possible right now. And then everything used by toStorePath might need to get moved to LockedFlake or somewhere in libexpr.