Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't log raw stderr #3576

Open
wants to merge 2 commits into
base: master
from
Open

build: don't log raw stderr #3576

wants to merge 2 commits into from

Conversation

@LnL7
Copy link
Member

LnL7 commented May 7, 2020

Second attempt, this time removing raw stderr from the build side instead of trying to determine what to show on the client.

LnL7 added 2 commits May 2, 2020
The raw stderr output isn't logged anymore so the build logs need to be
printed by the default logger in order for the old commands like
nix-build to still show build output.
With 7618695 structured build logs are now logged so no need to send
them over twice anymore.

Fixes #3556
Copy link
Member

Ma27 left a comment

While this fixes the issues I described in #3556 and #3558, I found another regression: when building a package using nix-build on a remote ssh://-builder, you won't get any build-logs (I had a Nix compiled from this branch running on both ends while testing this).

@LnL7
Copy link
Member Author

LnL7 commented May 10, 2020

Right, ssh doesn't implement RemoteStore so none of the logging is handled there.

I'm not sure removing raw stderr from the build side is the way to go then, until legacy ssh is removed. However that means there's no way to distinguish build logs from other output (like hash mismatches) unless those are all converted to a structured format.

@edolstra Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.