Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installables refactor #3583

Merged
merged 3 commits into from May 12, 2020
Merged

Installables refactor #3583

merged 3 commits into from May 12, 2020

Conversation

@mkenigs
Copy link
Contributor

mkenigs commented May 9, 2020

Simplifies the inheritance structure for Installables, so that parent classes only contain functionality used by all children. Makes Installables less interdependent with commands, and helps #3565

mkenigs added 3 commits May 9, 2020
InstallableValue has children InstallableFlake and InstallableAttrPath, but InstallableFlake was overriding toDerivations, and usage was changed so that InstallableFlake didn't need cmd. So these changes were made:
InstallableValue::toDerivations() -> InstalllableAttrPath::toDerivations()
InstallableValue::cmd -> InstallableAttrPath::cmd

InstallableValue uses state instead of cmd

toBuildables() and toDerivations() were made abstract
This reverts commit 883948d.
@edolstra edolstra merged commit fbade0b into NixOS:flakes May 12, 2020
2 checks passed
2 checks passed
tests (ubuntu-18.04)
Details
tests (macos)
Details
@edolstra
Copy link
Member

edolstra commented May 12, 2020

Thanks!

@mkenigs mkenigs deleted the mkenigs:InstallablesRefactor branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.