Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add fancy debug logs #3586

Open
wants to merge 1 commit into
base: master
from
Open

WIP: add fancy debug logs #3586

wants to merge 1 commit into from

Conversation

@mkg20001
Copy link
Member

mkg20001 commented May 11, 2020

No description provided.

@@ -162,7 +163,15 @@ static int _main(int argc, char * * argv)
bestLoad = load;
bestSlotLock = std::move(free);
bestMachine = &m;
} else {
debug("skipping '%s': there is a better machine", m.storeUri);

This comment has been minimized.

Copy link
@domenkozar

domenkozar May 13, 2020

Member

What does better mean?

This comment has been minimized.

Copy link
@mkg20001

mkg20001 May 13, 2020

Author Member

actually I'm not sure either, but I'm guessing it's based on the parameters above a machine that has a higher speed factor and is available right now

} else {
debug("skipping '%s': does not meet all condiditions\n - enabled = %s\n - system: type is matching = %s / required %s / got %s\n - features: all supported = %s / mandatory supported = %s / required %s / got %s", m.storeUri,
m.enabled,
std::find(m.systemTypes.begin(), m.systemTypes.end(), neededSystem) != m.systemTypes.end(), neededSystem, join(m.systemTypes, ","),

This comment has been minimized.

Copy link
@mkg20001

mkg20001 May 13, 2020

Author Member

the join() function call here should be replaced by the concatStringsSep() one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.