Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NIX_INSTALLER_NO_CHANNEL_ADD which skips nix-channel --add #3588

Merged
merged 2 commits into from May 13, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented May 12, 2020

Fixes #3575

@edolstra
Copy link
Member

edolstra commented May 12, 2020

Why an environment variable rather than a command line flag? Such variables are pretty undiscoverable.

@prusnak
Copy link
Member Author

prusnak commented May 12, 2020

In order to add a new command-line flag I'd need to rework the current naive flag handling.

I have no problem with this, but is that desired within the same PR?

Also, I followed something that seems to be a pattern (the only var exposed via a command-line flag is INSTALL_MODE). But I agree with the comment that:

Such variables are pretty undiscoverable.

@domenkozar
Copy link
Member

domenkozar commented May 12, 2020

@prusnak I think it's fine to do it as part of the same PR.

… flags
@prusnak
Copy link
Member Author

prusnak commented May 12, 2020

Added commit 9e12b2f which exposes installer config env vars via command line flags.

Review with -w / --ignore-all-space

@domenkozar domenkozar requested a review from edolstra May 13, 2020
@edolstra edolstra merged commit ecd4e52 into NixOS:master May 13, 2020
2 checks passed
2 checks passed
tests (ubuntu-18.04)
Details
tests (macos)
Details
@prusnak
Copy link
Member Author

prusnak commented May 13, 2020

Thanks!

@prusnak prusnak deleted the prusnak:nix-skip-channel-add branch May 13, 2020
@LnL7
Copy link
Member

LnL7 commented May 21, 2020

FYI this doesn't seem to work in combination with --daemon, that's still updating a channel for me.

@domenkozar
Copy link
Member

domenkozar commented May 22, 2020

Weird, the code seems to be correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.