Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle circular flake dependencies in list-inputs #3607

Merged
merged 2 commits into from May 28, 2020

Conversation

@mkenigs
Copy link
Contributor

@mkenigs mkenigs commented May 21, 2020

nix flake list-inputs currently segfaults for circular flake dependencies. This PR keeps track of visited nodes and only visits them once. Second commit adds a test that currently segfaults.

@domenkozar domenkozar requested a review from edolstra May 22, 2020
@edolstra
Copy link
Member

@edolstra edolstra commented May 28, 2020

Thanks!

@edolstra edolstra merged commit c3eff22 into NixOS:flakes May 28, 2020
0 of 2 checks passed
0 of 2 checks passed
tests (ubuntu-18.04) tests (ubuntu-18.04)
Details
tests (macos) tests (macos)
Details
@mkenigs mkenigs deleted the mkenigs:store-visited branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.