Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache tree in fetchOrSubstituteTree #3645

Merged
merged 3 commits into from Jun 2, 2020

Conversation

@mkenigs
Copy link
Contributor

mkenigs commented Jun 1, 2020

Caches tree in addition to lockedRef, and explicitly writes out the logic for different combinations of cached/uncached flakes and indirect/resolved/locked flakes. This eliminates uneccessary calls to lookupInFlakeCache, fetchTree, maybeLookupFlake, and flakeCache.push_back

mkenigs added 2 commits Jun 1, 2020
Caches tree in addition to lockedRef, and explicitly writes out the logic for different combinations of cached/uncached flakes and indirect/resolved/locked flakes. This eliminates uneccessary calls to lookupInFlakeCache, fetchTree, maybeLookupFlake, and flakeCache.push_back
@mkenigs mkenigs force-pushed the mkenigs:fetchOrSubstituteTree-improvements branch 4 times, most recently from 2016be5 to 1e4c2de Jun 1, 2020
@mkenigs mkenigs force-pushed the mkenigs:fetchOrSubstituteTree-improvements branch from 1e4c2de to c254254 Jun 1, 2020
@edolstra edolstra merged commit 7dbba0a into NixOS:flakes Jun 2, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
@edolstra
Copy link
Member

edolstra commented Jun 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.