Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hintfmt percent test, and fix #3724

Merged
merged 8 commits into from Jun 23, 2020
Merged

Hintfmt percent test, and fix #3724

merged 8 commits into from Jun 23, 2020

Conversation

@bburdette
Copy link
Contributor

bburdette commented Jun 19, 2020

In light of the issue from #3720, I thought adding some tests would be a good idea.

Also there's a tentative solution here... its maybe a little inelegant to search-and-replace on percent, but its simpler than some other things I thought of. Still thinking though.

src/libutil/fmt.hh Outdated Show resolved Hide resolved
Ericson2314 added a commit to obsidiansystems/nix that referenced this pull request Jun 21, 2020
There is a correctnes issue here, but NixOS#3724 will fix that. This is just
a cleanup for brevity's sake.
Co-authored-by: John Ericson <git@JohnEricson.me>
@bburdette bburdette changed the title WIP: Hintfmt percent test, and fix Hintfmt percent test, and fix Jun 22, 2020
…normaltxt on plain_string hintfmt
@edolstra edolstra merged commit 015e1c2 into NixOS:master Jun 23, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.