Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashed-mirrors: Use parsed derivation output rather than reconstructing it #3729

Merged
merged 1 commit into from Jun 29, 2020

Conversation

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 22, 2020

Now the derivation outputs are parsed up front, we can avoid a reparse
by doing it. Also, this just feels a bit better as the output* env
vars are more of a libnixexpr interface than libnixstore interface:
ultimately, it's the derivation outputs that decide whether the
derivation is fixed-output.

Yes, hashed mirrors might go away with #3689, but this bit of code would
be moved rather than deleted, so it's worth doing a cleanup anyways I
think.

…ng it

Now the derivation outputs are parsed up front, we can avoid a reparse
by doing it. Also, this just feels a bit better as the `output*` env
vars are more of a `libnixexpr` interface than `libnixstore` interface:
ultimately, it's the derivation outputs that decide whether the
derivation is fixed-output.

Yes, hashed mirrors might go away with #3689, but this bit of code would
be moved rather than deleted, so it's worth doing a cleanup anyways I
think.
@edolstra edolstra merged commit 58bc3b6 into NixOS:master Jun 29, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
@Ericson2314 Ericson2314 deleted the obsidiansystems:simpler-hased-mirror branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.