Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel tests fixes #3778

Merged
merged 2 commits into from Jul 3, 2020
Merged

Parallel tests fixes #3778

merged 2 commits into from Jul 3, 2020

Conversation

@regnat
Copy link
Contributor

regnat commented Jul 2, 2020

Fix the issues introduced by #3777

  • Restore tests/plugins/libplugintest.* as a dependency of the testsuite
  • Shorten the path to the test root to fix a socket path is too long error on the OSX builders
@regnat
Copy link
Contributor Author

regnat commented Jul 2, 2020

(waiting for the CI to confirm the OSX fix as I can't test it locally)

@regnat regnat mentioned this pull request Jul 2, 2020
@Ericson2314
Copy link
Member

Ericson2314 commented Jul 3, 2020

Maybe we can use relative paths when we create the socket to get around this?

@regnat regnat force-pushed the tweag:parallel-tests branch from 4c37fcb to 26ca796 Jul 3, 2020
@regnat
Copy link
Contributor Author

regnat commented Jul 3, 2020

Maybe we can use relative paths when we create the socket to get around this?

I tried that but it's not allowed

I managed to work around the path length by directly putting the daemon socket under $TEST_ROOT in the tests. In theory the error can still happen if $TMPDIR is too long, but that gives us roughly as much margin as what we used to have before.

Now I'm stuck again with a non-sensical error on the OSX builder 😠 (the nix-shell test fails on a call to nix develop, except that I couldn't find any call to nix develop in the whole codebase, so I have no idea where this can come from)

@regnat
Copy link
Contributor Author

regnat commented Jul 3, 2020

Now I'm stuck again with a non-sensical error on the OSX builder angry

Mh, the same pipeline passed on Tweag's repo (https://github.com/tweag/nix/runs/833213722). I'll try force-pushing to restart the pipeline and see if the failure persists

@regnat regnat force-pushed the tweag:parallel-tests branch from 26ca796 to 06bcd93 Jul 3, 2020
regnat added 2 commits Jul 2, 2020
Reuse the pre-existing list rather than the one written as part of #3777
Fix a socket length failure on the OSX builders
@regnat regnat force-pushed the tweag:parallel-tests branch from 06bcd93 to 223fbe6 Jul 3, 2020
@edolstra
Copy link
Member

edolstra commented Jul 3, 2020

Looks like there is also a dependency on tests/config.nix missing: https://nix-cache.s3.amazonaws.com/log/r2qnl4d2k9ix8i2gbi816x6lszmjgf6z-nix-2.4pre7875_5596f879.drv

@regnat
Copy link
Contributor Author

regnat commented Jul 3, 2020

Looks like there is also a dependency on tests/config.nix missing

Yup', I've also restored it in this branch

The OSX failure now seems to be a real one introduced by 5596f87 (I've tried rebasing it on top of yesterday's master removing the "parallel tests" MR, and it still fails: https://github.com/tweag/nix/runs/833623967)

@edolstra edolstra merged commit dfaad37 into NixOS:master Jul 3, 2020
0 of 2 checks passed
0 of 2 checks passed
tests (ubuntu-latest) tests (ubuntu-latest)
Details
tests (macos-latest) tests (macos-latest)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.