Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error messages for issue 2238 #3897

Merged
merged 3 commits into from Aug 6, 2020
Merged

error messages for issue 2238 #3897

merged 3 commits into from Aug 6, 2020

Conversation

@bburdette
Copy link
Contributor

bburdette commented Aug 5, 2020

Added a logError to build-remote to show the failure together with system info; added a check to the existing error site and reworded the error there. Added a link to docs.

Here's the tail end of the result from

sudo nix-store -j0 --realise --option substitute false --builders 'ssh://root@10.0.0.237 x86_64-linux - - - foo foo' /nix/store/crv8z01l69c3y0scq4cvdgyxrk2ldd1f-rustc-1.45.0.drv 

Selection_052

@bburdette
Copy link
Contributor Author

bburdette commented Aug 5, 2020

@edolstra edolstra merged commit 3321b2b into NixOS:master Aug 6, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
@edolstra
Copy link
Member

edolstra commented Aug 6, 2020

Thanks!

@bburdette bburdette deleted the bburdette:error-2238 branch Aug 6, 2020
@B4dM4n
Copy link
Contributor

B4dM4n commented Aug 11, 2020

This PR adds the following error to all nix builds for me, but the builds still succeed:

% nix build --impure --expr 'with import <nixpkgs> { }; runCommand "test" { } "touch $out"'
error: --- Remote build --- build-remote
Failed to find a machine for remote build!

required (system, features): (x86_64-linux, )
2 available machines:
(systems, maxjobs, supportedFeatures, mandatoryFeatures)
(x86_64-darwin, 2, , )
(x86_64-darwin, 2, , )
% realpath result
/nix/store/ml206rqibmzwffbbqssq879fj8jpivkb-test
@bburdette
Copy link
Contributor Author

bburdette commented Aug 11, 2020

This PR adds the following error to all nix builds for me, but the builds still succeed:

Yeah, its only in retrospect that we can say it was a critical error - when neither remote nor local build is possible. In your case it appears to be a normal part of the build. Maybe this is better as an warning, or even just an Info level message.

@nh2
Copy link
Contributor

nh2 commented Aug 13, 2020

This PR adds the following error to all nix builds for me, but the builds still succeed:

You can use --max-jobs 0 to force building on remotes only, see #1572 (comment) (with the exception of #3810).

@nh2
Copy link
Contributor

nh2 commented Aug 13, 2020

I made a follow-up PR to add more details in #3927.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.