Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs updates #3982

Merged
merged 2 commits into from Sep 7, 2020
Merged

Minor docs updates #3982

merged 2 commits into from Sep 7, 2020

Conversation

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 1, 2020

After the new markdown docs were merged, the Hacking link broke.

Additionally, when I was trying to hack on Nix yesterday, I was confused as to why make install was trying to access /usr, whereas the Hacking page noted Nix would be installed to ./inst. I had to look at https://hydra.nixos.org/build/126292991/download/1/manual/installation/building-source.html to realize I needed to pass --prefix=$(pwd)/inst when configuring for the Hacking page to be accurate. Thus, I've added the flag to the page.

cole-h added 2 commits Sep 1, 2020
Otherwise, the steps advertised in this document won't actually work
(e.g. `make install` will fail, trying to access /usr, and
`./inst/bin/nix` won't exist).
@cole-h cole-h mentioned this pull request Sep 7, 2020
@vcunat vcunat merged commit 77d4758 into NixOS:master Sep 7, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
@cole-h cole-h deleted the cole-h:minor-docs branch Sep 7, 2020
@vcunat
Copy link
Member

@vcunat vcunat commented Sep 7, 2020

Well, I don't really feel entitled for push access anymore, but I think it I can fairly safely say this PR is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.