Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add a fish shell file to correctly source vars (#3980) #3985

Closed
wants to merge 1 commit into from

Conversation

@Jiehong
Copy link

@Jiehong Jiehong commented Sep 2, 2020

I don't understand how nix-profile.sh.in gets turned into nix-profile.sh, so this PR might be missing something.

@@ -247,3 +247,42 @@ variables are set, either log in again, or type
in your shell.
EOF
fi

added=
p=$HOME/.nix-profile/etc/profile.d/nix.fish

This comment has been minimized.

@Jiehong

Jiehong Sep 2, 2020
Author

I'm assuming nix-profile.fish.in is converted to nix.fish somehow, but that's unclear.

@edolstra
Copy link
Member

@edolstra edolstra commented Sep 2, 2020

See #440. The main problem with adding fish support is that it will quickly get out of sync with the bash profile script, since the maintainers (e.g. me) don't use fish.

@Jiehong
Copy link
Author

@Jiehong Jiehong commented Sep 2, 2020

See #440. The main problem with adding fish support is that it will quickly get out of sync with the bash profile script, since the maintainers (e.g. me) don't use fish.

Ah, I didn't see that one. I just read it, and saw what people tried to do there.

I understand your concern here.

Perhaps an alternative would be to display a message if the user has fish installed, saying that nix will only work in bash?

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 2, 2020

Maybe we could suggest https://github.com/lilyball/nix-env.fish/. When I was using Nix on Arch, that plugin saved my sanity.

@Jiehong
Copy link
Author

@Jiehong Jiehong commented Sep 18, 2020

This won't be merged, as the team won't maintain non-bash scripts.

Instead, I made a new PR to display a message instead: #4033

@Jiehong Jiehong closed this Sep 18, 2020
@Ericson2314 Ericson2314 mentioned this pull request Sep 28, 2020
2 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.