Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nix.conf option for allowing a symlinked store #4038

Merged
merged 4 commits into from Sep 22, 2020

Conversation

@maljub01
Copy link
Contributor

@maljub01 maljub01 commented Sep 18, 2020

Using an environment variable for allowing a symlinked store is currently broken, and is extremely brittle (See #4022). This is because nix invocations that happen in a different environment than the user's will still return errors complaining about the symlink (ex. through sudo or the nix-daemon).

Fixes #2926.

src/libstore/globals.hh Outdated Show resolved Hide resolved
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Looks good. In fact, i would like to have a policy that for every env var there exists a more proper configuration option (be it global, per store, etc.)

@maljub01 maljub01 requested a review from edolstra Sep 21, 2020
@maljub01
Copy link
Contributor Author

@maljub01 maljub01 commented Sep 21, 2020

Looks good. In fact, i would like to have a policy that for every env var there exists a more proper configuration option (be it global, per store, etc.)

Agreed! What would the process be to try to make that happen?

@edolstra
Copy link
Member

@edolstra edolstra commented Sep 21, 2020

In fact we should just get rid of the environment variable. The only reason it exists is that it was a hack (which probably shouldn't have been documented...) and we didn't have a config file back then.

@edolstra edolstra merged commit 5b107f2 into NixOS:master Sep 22, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest)
Details
tests (macos-latest)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.