Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title for nix-env #4096

Closed
wants to merge 1 commit into from
Closed

Remove title for nix-env #4096

wants to merge 1 commit into from

Conversation

@pickfire
Copy link

@pickfire pickfire commented Oct 1, 2020

No description provided.

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

Hi @pickfire, can you take the time to explain why this change makes sense?

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 1, 2020

The title field is metadata for lowdown so we can't remove it. It would be nice if it didn't appear in the HTML manual but there is no easy way to do that.

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 1, 2020

Isn't something like

---
title: nix-env
---

a thing people do in markdown for this?

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

That's called front matter, and yeah, it's a thing.

I'm still wondering if this pull request is a product of the hacktoberfest.

@pickfire
Copy link
Author

@pickfire pickfire commented Oct 1, 2020

Huh? Oh, I forgot yesterday when I send this hactoberfest already started (I do want to do hacktoberfest but I bet 4 pulls are easy). No, it wasn't because of hacktoberfest, I was just browsing nix docs and I noticed this weird thing in nix-env https://nixos.org/manual/nix/unstable/command-ref/nix-env.html, looks like it is also there for nix-build but I don't see this in all pages.

Okay, I didn't know this is part of frontmatter since they usually have --- so I thought it was part of failed migration to new unstable docs. Should I change it to ---?

By the way, happy mid-autumn festival (yesterday)! :D

@edolstra edolstra closed this in 58dadf2 Oct 8, 2020
@pickfire pickfire deleted the patch-1 branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants