Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing includes causing build failure #4105

Closed
wants to merge 1 commit into from

Conversation

@stephank
Copy link
Contributor

@stephank stephank commented Oct 3, 2020

I was trying to get Nix master (57b935a) to build on Darwin using nix-shell, but ran into missing string & string_view includes in several places. Curiously, it does build with nix build --rebuild, but I don't understand the difference.

@edolstra
Copy link
Member

@edolstra edolstra commented Nov 19, 2020

I don't think these should be necessary. For instance, including <string> before types.hh shouldn't do anything since the latter already includes the former.

@edolstra edolstra closed this Nov 19, 2020
@stephank
Copy link
Contributor Author

@stephank stephank commented Nov 21, 2020

Whatever the issue was, it seems to have disappeared. Strange! Thanks for taking the time to look.

@stephank stephank deleted the fix-build branch Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants