Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support name attribute in fetchGit #4116

Closed
wants to merge 1 commit into from

Conversation

@AmineChikhaoui
Copy link
Member

@AmineChikhaoui AmineChikhaoui commented Oct 7, 2020

I think this was accidentally removed during the refactoring of
fetch{Tree,Git} which introduced issues such as:

unsupported Git input attribute 'name'
I think this was accidentally removed during the refactoring of
fetch{Tree,Git} which introduced issues such as:

```
unsupported Git input attribute 'name'
```
@AmineChikhaoui
Copy link
Member Author

@AmineChikhaoui AmineChikhaoui commented Oct 7, 2020

I'm not sure the failures in the checks are false positives or not.

@AmineChikhaoui
Copy link
Member Author

@AmineChikhaoui AmineChikhaoui commented Oct 8, 2020

@edolstra does this look good to you ?

@AmineChikhaoui
Copy link
Member Author

@AmineChikhaoui AmineChikhaoui commented Jan 1, 2021

@edolstra would you mind just adding the simple change name != "name" so that fetchGit would support name as attribute ?

@AmineChikhaoui AmineChikhaoui deleted the fetchgit-name branch Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant