Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic std::optional<T> suppport from worker proto #4120

Merged
merged 1 commit into from Oct 7, 2020

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 7, 2020

See comment for rational; I think it's good to leave a comment lest anyone is tempted to add such a sum-type instance again.

Fixes #4113

See comment for rational; I think it's good to leave a comment lest
anyone is tempted to add such a sum-type instance again.

Fixes #4113
@edolstra edolstra merged commit 5257a25 into NixOS:master Oct 7, 2020
2 checks passed
2 checks passed
tests (ubuntu-latest) tests (ubuntu-latest)
Details
tests (macos-latest) tests (macos-latest)
Details
@Ericson2314 Ericson2314 deleted the obsidiansystems:no-poly-sum-worker-proto branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.