Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSH completion should be written like this #4132

Closed
wants to merge 1 commit into from

Conversation

@doronbehar
Copy link

@doronbehar doronbehar commented Oct 10, 2020

The previous script was a script one needs to source. This script is a script one adds to their ZSH fpath. See:
https://unix.stackexchange.com/a/33898/135796

cc @regnat

More over, Nixpkgs should chose this script here if nixUnstable is used:

https://github.com/NixOS/nixpkgs/blob/763bbfde7c3f3aa7f84b443b0c3fbbbd2c35f53e/nixos/modules/programs/zsh/zsh.nix#L281-L282

The previous script was a script one needs to `source`. This script is a
script one adds to their ZSH fpath. See:
https://unix.stackexchange.com/a/33898/135796
@doronbehar
Copy link
Author

@doronbehar doronbehar commented Oct 10, 2020

Haven't seen spwhitt/nix-zsh-completions#34 . Closing.

@doronbehar doronbehar closed this Oct 10, 2020
@regnat
Copy link
Contributor

@regnat regnat commented Oct 12, 2020

Given the size of this completion script, I think it's nice to have it in the Nix codebase itself so that we have at least a simple completion works out-of-the box, so it's totally fine to reopen this imho

@doronbehar
Copy link
Author

@doronbehar doronbehar commented Oct 12, 2020

Yes but it's not even installed, so it seems:

nix/Makefile

Lines 14 to 17 in 20d2140

misc/bash/local.mk \
misc/systemd/local.mk \
misc/launchd/local.mk \
misc/upstart/local.mk \

If this PR would also make it get installed, we'll have collisions in NixOS systems:

https://github.com/NixOS/nixpkgs/blob/763bbfde7c3f3aa7f84b443b0c3fbbbd2c35f53e/nixos/modules/programs/zsh/zsh.nix#L281-L282

non-NixOS users might benefit from this change (without making it get installed) but I would recommend them anyway to use nix-zsh-completions directly, so I don't care enough to maintain this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.