Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert VM tests to Python #4156

Merged
merged 2 commits into from Oct 17, 2020
Merged

Convert VM tests to Python #4156

merged 2 commits into from Oct 17, 2020

Conversation

@aszlig
Copy link
Member

@aszlig aszlig commented Oct 17, 2020

Perl-based tests are deprecated since NixOS 20.03 and subsequently got removed in NixOS 20.09, which effectively means that tests are going to fail as soon as we build it with NixOS 20.09 or anything newer.

I've put # fmt: off at the start of every testScript, because formatting with Black really messes up indentation and I don't think it really adds anything in value or readability for inlined Python scripts.

aszlig added 2 commits Oct 17, 2020
Perl-based tests are deprecated since NixOS 20.03 and subsequently got
removed in NixOS 20.09, which effectively means that tests are going to
fail as soon as we build it with NixOS 20.09 or anything newer.

I've put "# fmt: off" at the start of every testScript, because
formatting with Black really messes up indentation and I don't think it
really adds anything in value or readability for inlined Python scripts.

Signed-off-by: aszlig <aszlig@nix.build>
Having vm-test-run-unnamed for all the test derivation doesn't look very
nice, so in order to better distinguish them from their store path,
let's actually give them proper names.

Signed-off-by: aszlig <aszlig@nix.build>
@edolstra edolstra merged commit 05e6fe6 into NixOS:master Oct 17, 2020
2 checks passed
2 checks passed
@github-actions[bot]
tests (ubuntu-latest) tests (ubuntu-latest)
Details
@github-actions[bot]
tests (macos-latest) tests (macos-latest)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants